Add intergration seam to Logger#172
Open
KevM wants to merge 1 commit intosta:masterfrom
Open
Conversation
Owner
|
Hello there, thanks for your pull request. I would like to merge this fix, but how does this change the log level (, set the file output, and change the output behavior)? |
Author
|
Hello back, It does not change the log level or any existing behavior. This PR simply exposes a seam for users to change out the built in logger with their own. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our usage of websocket-sharp we need to integrate our logging infrastructure with websocket-sharp's. This PR adds a seam which allows the Logger implementation to be swapped out. Existing users are not affected.
Downstream users wishing to use their own logger would simply use the
Logsetter:Example integration
Below is an integration example for plain Log4Net.
Thank you for your consideration. Let me know if there is anything I can do to improve this PR.