fix(ci): restore ruff/mypy audit green after #2555 (format + baseline line-shifts) - #2947
Merged
Merged
Conversation
…ne line-shifts The #2555 merge (a550042) tripped the two pull_request-only audit workflows (mypy-audit, ruff-audit); every other CI leg -- muninn, full-suite, both crucible legs, smoke-test on all platforms, CodeQL -- passed. These audits run only on `pull_request`, not on push to main, so the auto-merge landed the change before they could gate it. Two causes, both addressed here: - ruff format (zero-tolerance): the new `doc_languages` set comprehension in _get_dominant_lang exceeded the line limit; wrapped to be `ruff format`-clean. - Baseline line-shifts (NOT new findings): the #2555 edits pushed two pre-existing baselined findings down by a few lines. Updated the keys to match -- ruff C401 guidestar_lens.py 139 -> 149 (the has_intent Sector-Bias generator), mypy assignment galaxyscope.py 368 -> 370. Baseline keys are {file}:{line}: {code} and the CI check is keys-only, so these are the exact line numbers CI's pinned ruff 0.16.0 / mypy will compute. Baselines re-normalized to the documented json.dump(indent=2, sort_keys=True) form. Verified locally: `ruff_audit.py --ci` and `mypy_audit.py --ci` both report no new findings beyond baseline; signal_processor + #2555 tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SpojRfky4j31UMHLDcPdto
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The #2555 merge (
a550042f) tripped the twopull_request-only audit workflows —mypy-auditandruff-audit. Every other CI leg passed on that same code (muninn, full-suite, both crucible legs, smoke-test on all platforms, CodeQL, …). Because those audits run only onpull_request(not on push tomain) and the repo's auto-merge lands PRs immediately, the change merged before they could gate it.Opened as a draft on purpose so the audit workflows run and gate this fix before it merges.
What
Two causes, both addressed:
ruff format(zero-tolerance): the newdoc_languagesset comprehension in_get_dominant_langexceeded the line limit — wrapped to beruff format-clean.Baseline line-shifts (not new findings): the dominant language inconsistency: reports PLAINTEXT while composition table shows JAVASCRIPT 53.8% #2555 edits pushed two pre-existing baselined findings down a few lines. Updated the keys to match:
C401guidestar_lens.py139 → 149assignmentgalaxyscope.py368 → 370Baseline keys are
{file}:{line}: {code}and the audit's CI check is keys-only, so these are the exact line numbers CI's pinned ruff 0.16.0 / mypy will compute (line numbers are version-independent). Baselines re-normalized to the documentedjson.dump(indent=2, sort_keys=True)form.Verification
python tests/ruff_audit.py --ci→ no NEW findings beyond the 26-finding baseline;ruff format --checkclean.python tests/mypy_audit.py --ci→ no NEW type errors beyond the 2-error baseline.signal_processor+#2555tests pass (75).Follow-up to #2555.
🤖 Generated with Claude Code