Repository navigation
Fix Zoho OIDC nonce compatibility - #1468
Merged
Merged
Conversation
Closed
lovasoa
force-pushed
the
codex/zoho-oidc-nonce
branch
from
September 17, 2026 20:40
d319fd5 to
8a58814
Compare
lovasoa
marked this pull request as ready for review
September 17, 2026 20:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zoho Accounts rejects OIDC nonce values containing
=before authentication. SQLPage used an Argon2 PHC hash as the nonce, and PHC hashes contain=.Encode the PHC value as unpadded base64url for the authorization request, then decode it before the existing Argon2 verification. This preserves strict nonce validation while limiting the transmitted nonce to URL-safe characters.
Fixes #1466.
Validation:
cargo test --test mod oidccargo clippy --all-targets --all-features -- -D warningsDraft pending a manual Zoho end-to-end sign-in and green GitHub Actions.