Skip to content

fix: assume chainID is float64 #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MakMuftic merged 1 commit into from
Sep 1, 2026
Merged

fix: assume chainID is float64 #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ func MergeChainConfigs(chainConfigs []map[string]interface{}, solverConfig solve
}

cc := map[string]interface{}{
"id": id,
"id": float64(id),
"type": "evm",
"name": fmt.Sprintf("chain-%d", id),
"endpoint": c.Transport.HTTP[0],
Expand All @@ -166,8 +166,8 @@ func MergeChainConfigs(chainConfigs []map[string]interface{}, solverConfig solve

func chainExists(chainConfigs []map[string]interface{}, chainID uint64) bool {
for _, cc := range chainConfigs {
ccID := cc["id"].(uint64)
if ccID == chainID {
ccID := cc["id"].(float64)
if uint64(ccID) == chainID {
return true
}
}
Expand Down
6 changes: 3 additions & 3 deletions config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ func (s *MergeChainConfigsTestSuite) Test_MergeChainConfigs_AddsChainFromSolverC

s.Len(merged, 1)
s.Equal(map[string]interface{}{
"id": uint64(10),
"id": float64(10),
"type": "evm",
"name": "chain-10",
"endpoint": "https://chain10.example",
Expand All @@ -620,7 +620,7 @@ func (s *MergeChainConfigsTestSuite) Test_MergeChainConfigs_ManuallyConfiguredCh

manual := []map[string]interface{}{
{
"id": uint64(10),
"id": float64(10),
"endpoint": "https://custom.example",
"admin": "adminAddress",
},
Expand All @@ -634,7 +634,7 @@ func (s *MergeChainConfigsTestSuite) Test_MergeChainConfigs_ManuallyConfiguredCh
func (s *MergeChainConfigsTestSuite) Test_MergeChainConfigs_KeepsManualOnlyChains() {
manual := []map[string]interface{}{
{
"id": uint64(99),
"id": float64(99),
"type": "evm",
"endpoint": "https://manual-only.example",
"name": "manual99",
Expand Down
Loading