Conversation
Closes spring-projectsgh-19725 Signed-off-by: Hyunwoo Jung <hyunwoojung@kakao.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The messages in these assertions are produced by the JDK's XML parser and are localized based on the default locale, so they are not stable values for the tests to depend on.
I think asserting
XmlBeanDefinitionStoreExceptionwith aSAXParseExceptionroot cause is sufficient here. The purpose of these tests is to verify that the invalid XML configuration fails schema validation, rather than to verify the exact diagnostic message produced by Xerces.This change removes the locale-dependent message assertions while retaining the exception type assertions.
Closes gh-19725