Skip to content

Add @Nullable annotations when treating Map.remove() as returning @Nullable#37067

Closed
msridhar wants to merge 1 commit into
spring-projects:mainfrom
msridhar:map-remove-nullable
Closed

Add @Nullable annotations when treating Map.remove() as returning @Nullable#37067
msridhar wants to merge 1 commit into
spring-projects:mainfrom
msridhar:map-remove-nullable

Conversation

@msridhar

Copy link
Copy Markdown
Contributor

The next release of NullAway treats Map.remove as returning @Nullable, leading to errors at these locations. Fix them by marking the return type as @Nullable.

…ing @nullable

Signed-off-by: Manu Sridharan <msridhar@gmail.com>
@msridhar
msridhar force-pushed the map-remove-nullable branch from 9d50730 to a2ca851 Compare July 18, 2026 19:35
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 18, 2026
@msridhar

Copy link
Copy Markdown
Contributor Author

This PR will fix the build failures when updating to NullAway 0.13.8

@sbrannen sbrannen self-assigned this Jul 20, 2026
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 20, 2026
@sbrannen sbrannen changed the title Add @Nullable annotations required when treating Map.remove as returning @Nullable Add @Nullable annotations when treating Map.remove() as returning @Nullable Jul 20, 2026
@sbrannen sbrannen added this to the 7.0.9 milestone Jul 20, 2026
sbrannen pushed a commit that referenced this pull request Jul 20, 2026
…Nullable

Closes gh-37067

Signed-off-by: Manu Sridharan <msridhar@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

Fixed via 233725c

@github-actions github-actions Bot closed this Jul 20, 2026
@sbrannen

Copy link
Copy Markdown
Member

This has been merged into 7.0.x and main.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants