Repository navigation
ci: publish to npm with trusted publishing only - #6
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently remove staging behavior while preserving OIDC permissions and requiring successful npm publishing before GitHub Release creation.
No open issues 🎉
What changed in this PR
This PR simplifies release automation to publish exclusively through npm trusted publishing (OIDC) and create published GitHub Releases.
Changes:
- Removes the stage-only token, staging step, and staged output.
- Makes npm publishing unconditional within the publish job.
- Removes draft handling from GitHub Release creation.
| File | Description |
|---|---|
.github/workflows/publish.yml |
Removes staging and draft-release behavior while retaining OIDC publishing. |
Review effort: Balanced
Samy-O7
approved these changes
Oct 26, 2026
Samy-O7
left a comment
There was a problem hiding this comment.
Approving at c057e8b. Checked:
- The stage-only token path is fully removed: no stage step,
NPM_STAGE_TOKENor draft-release handling is left. The publish job has onlycontents: readandid-token: write, and the release job creates the GitHub Release published. - Running the Pack step's
npm sbomand the new rename locally gives an SBOM whose root is@spreedly/composer-sdk-server; the 1.0.0 SBOM was named after the checkout folder (composer-sdk-server-node). The package has no runtime dependencies, so no components are missing. - Both Client SDK links in the README now point to https://www.npmjs.com/package/@spreedly/composer-sdk-client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
publish.yml:npm sbomnames it after the checkout folderREADME.md: point the Client SDK links to@spreedly/composer-sdk-client