Clarify that midi_tempo only sets MIDI header tempo, not note timing.#193
Open
candpixie wants to merge 1 commit into
Open
Clarify that midi_tempo only sets MIDI header tempo, not note timing.#193candpixie wants to merge 1 commit into
candpixie wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #152.
Changed documentation only. Referenced Issue #152, which reports that
midi_tempodoesn'taffect playback speed. It's correct: in
note_events_to_midi,midi_tempois only passed to
pretty_midi.PrettyMIDI(initial_tempo=...), which writes thetempo into the MIDI header. Note
start/endtimes come from the audio inabsolute seconds and are never rescaled by
midi_tempo, so it cannot changetiming or duration but only the header value.
This PR helps clarify that in the
--midi-tempoCLI help and in the docstrings fornote_events_to_midi,predict, andpredict_and_save(which previouslyomitted
midi_tempo). Also, no behavior changes have been made.