Skip to content

feat(classmap): 1020092 verified classmap for Spotify 1.2.92#2

Open
afonsojramos wants to merge 5 commits into
mainfrom
feat/classmap-1020092
Open

feat(classmap): 1020092 verified classmap for Spotify 1.2.92#2
afonsojramos wants to merge 5 commits into
mainfrom
feat/classmap-1020092

Conversation

@afonsojramos

@afonsojramos afonsojramos commented Jul 21, 2026

Copy link
Copy Markdown
Member

What

First newly-produced classmap since 1020045 (Sep 2024): 1020092 for Spotify 1.2.92.148, generated with the new migration + verification pipeline (see spicetify/cli#3896) from the 1020040 base.

Verification

  • 21/36 leaves verified on a live stock 1.2.92.148 client: 19 via CDP e2e with deep navigation (home, search, library, playlist, context menu, settings), 2 via manual DOM probe of the preferences page.
  • All required paths verified: playbar, topbar, navbar, tracklist, context menu, search box, search chips, sort box, settings button/header/section.
  • 6 modal leaves unverified (credits/embed modals were not opened during navigation); they keep migrate values.
  • 9 stale leaves keep their 1.2.40 base hashes and are flagged in META.json (including 1 leaf the CDP run falsified, which was reverted to stale).

Two zero-evidence semantic matches falsified by CDP were re-mapped by hand (settings.header.container, settings.section.container).

META.json carries the full per-leaf verification breakdown.

Notes

  • Historical backfill (1.2.46-1.2.91) is not feasible: no public source of old xpui CSS exists (xpui-archive stops at 1.2.42, the deb pool keeps only latest). The operating model going forward is: capture each new Spotify release as it ships, migrate, CDP-verify, publish.
  • Once merged, flipping 1.2.92 to status: modular in the CLI's supported-versions.json (stacked PR feat(cli): classmap-aware support reporting and migration tooling cli#3896).

Summary by CodeRabbit

  • Improvements

    • Updated compatibility mappings across navigation, playback controls, search, settings, menus, dialogs, and track information views.
    • Added/updated CSS class mappings for key UI elements, including active and modifier states (e.g., playbar/navigation indicators, search chips, and context menu layouts).
  • Quality

    • Expanded and documented UI verification coverage, including settings-related containers and interactive controls.
    • Reported verification results to improve reliability and reduce interface mismatch risk.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c3f7f8ae-3f24-4fb7-904d-5d01d6fc3043

📥 Commits

Reviewing files that changed from the base of the PR and between 185f8e6 and afec2dd.

📒 Files selected for processing (3)
  • 1020092/META.json
  • 1020092/classmap-19f8522e902.json
  • 1020092/css-map.json
🚧 Files skipped from review as they are similar to previous changes (3)
  • 1020092/META.json
  • 1020092/css-map.json
  • 1020092/classmap-19f8522e902.json

Walkthrough

Adds Spotify UI class mappings, three CSS semantic mappings, and verification metadata for classmap key 1020092, including pipeline details, DOM guards, required paths, statistics, stale entries, and verification notes.

Changes

Classmap 1020092

Layer / File(s) Summary
Classmap definitions, CSS mappings, and verification metadata
1020092/classmap-19f8522e902.json, 1020092/css-map.json, 1020092/META.json
Adds mappings for UI areas, tracklists, search controls, modals, settings, and menus; maps three hashed classes to CSS identifiers; and records verification status, paths, guards, statistics, stale entries, and notes.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A rabbit hops through classes bright,
With hashed paths arranged just right.
Metadata checks each leafy trail,
CSS leaves join the verification tale.
“New maps!” it cheers beneath the moon.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding a verified classmap for Spotify 1.2.92.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/classmap-1020092

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@1020092/classmap-19f8522e902.json`:
- Around line 32-36: Replace the duplicated hashes in
1020092/classmap-19f8522e902.json: at lines 32-36, assign distinct verified
hashes to button.wrapper__active and button.wrapper__indicator; at lines 40-44,
assign container__active its distinct state hash; and at lines 53-58, assign
search_chips.chip a child-element hash distinct from wrapper. Obtain the correct
values through manual DOM probing, then update the corresponding META.json
verification statistics and notes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e8afd896-d2ad-479d-99dd-f388c61de46b

📥 Commits

Reviewing files that changed from the base of the PR and between 3b305f0 and 8e6a694.

📒 Files selected for processing (2)
  • 1020092/META.json
  • 1020092/classmap-19f8522e902.json

Comment thread 1020092/classmap-19f8522e902.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant