fix(tui): render hyperlinks in one pass without cursor flicker - #228
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Render native terminal hyperlinks through a custom Ratatui backend instead of a separate post-frame repaint. Keep the cursor hidden during rendering and synchronize the complete frame to prevent cursor flashes at intermediate draw positions.
Technical details
Single-pass hyperlink updates
Merge hyperlink metadata changes with Ratatui鈥檚 cell diff so changed targets and removed links update even when their text is unchanged, without printing those cells twice. Preserve wide-grapheme draw ordering, skipped image cells, overlay behavior, and the exclusion of internal
kit-image:targets from native hyperlinks.Frame and cursor lifecycle
Route both TUI draw paths through a shared synchronized-update helper and defer cursor visibility until final positioning. Attempt hyperlink closure, cursor restoration, and synchronized-update cleanup after output errors; terminal panic cleanup also closes hyperlinks and ends synchronized updates.