File cleanup support - #58
Merged
Merged
Conversation
Signed-off-by: John Parent <john.parent@kitware.com>
johnwparent
force-pushed
the
file-cleanup-support
branch
from
August 5, 2026 21:36
82e4a85 to
1404535
Compare
Signed-off-by: John Parent <john.parent@kitware.com>
scheibelp
requested changes
Aug 5, 2026
scheibelp
left a comment
scheibelp
left a comment
Member
There was a problem hiding this comment.
I have one request and a couple questions
uses "scopedfile" instead adds move semantics for easier construction wraps in a unique ptr in linkerinvocation Signed-off-by: John Parent <john.parent@kitware.com>
scheibelp
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Parent john.parent@kitware.com