Repository navigation
Conversation
Export the producer-owned snapshot from the current product source: 422 public and 443 partner operations, 632 error codes, and the CLI, changelog, setup, and redirect references. The public-safety scan now skips hex runs inside a UUID, so the nil and max UUID sentinels in schema patterns pass while a bare short commit hash next to them still fails. A behavioral test covers both and runs with the scan. The Internals rule matches home-directory paths only at a path boundary, so CLI command paths like src/commands/users/ are not flagged. Add spelling exceptions for new reference vocabulary.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| @@ -21,7 +21,7 @@ $ npm install -g spacefast | |||
| $ sf COMMAND | |||
| running command... | |||
| $ sf (--version) | |||
| spacefast/0.3.0 | |||
| spacefast/0.5.0 | |||
| $ sf --help [COMMAND] | |||
There was a problem hiding this comment.
🟡 Bug · CLI reference and package changelogs document unreleased 0.5.0
npm view spacefast dist-tags gives latest: 0.4.1, the @spacefast/* packages top out at 0.4.1, and neither spacefast/cli nor the monorepo has a v0.5.0 tag. I diffed the oclif.manifest.json from the published 0.4.1 tarball against the ## \sf …`headings here. These are documented but ship in no release:auth as, auth reset, connectors connections reconnect, db list, dev run-many, domains update, rules (+add/ls/pause/resume/rm/test/validate), spaces archive/restore, storage get/put, users (+delete/get/ls/reactivate/revoke/sessions/settings/suspend), and zero queries. sf git webhooks` still ships in 0.4.1 but is no longer documented.
A reader who runs npm install -g spacefast and follows this page gets "command not found". AGENTS.md says to document shipped, publicly verifiable behavior only. generated/changelog/packages/*.md has the same problem with the ## 0.5.0 sections.
There was a problem hiding this comment.
Agreed, and this gates the PR. The exporter builds the CLI reference and package changelogs from source, which is at 0.5.0, while npm latest is 0.4.1. There's no clean partial refresh, since the manifest owns the whole snapshot. So this waits until 0.5.0 is published to npm, then gets re-exported. Leaving this thread open as the merge guard.
There was a problem hiding this comment.
Makes sense to hold it on this thread. I confirmed 026437a fixes the other two: the "See code" links are gone and the UUID exemption now covers only the sentinels. Both are marked resolved.
One more thing to fix before merge, separate from the 0.5.0 wait. The snapshot drops space_quota_exceeded, deploy_quota_exceeded, and build_minutes_quota_exceeded, but four authored pages still name them: content/api/errors.mdx, content/(account)/usage.mdx, content/(reference)/limits.mdx, and content/(publish)/anonymous-and-claim.mdx. The space and build-minute limits now return quota_exceeded, and the daily deploy allowance only warns. These pages aren't generated, so they can be fixed in this PR now.
There was a problem hiding this comment.
Fixed the retired quota codes in eeec686. errors.mdx, usage.mdx, limits.mdx, and anonymous-and-claim.mdx now say quota_exceeded (limits/enforce.ts, from #3045, which is in production). The deploy and build-minute rows are dropped from the errors table. This thread stays open as the 0.5.0 merge guard.
Re-export without the CLI reference's per-command source links, which pointed into a private repository. The Internals path-boundary change is no longer needed and is reverted. Exempt only the nil and max UUID sentinels from the short-hash scan so a pasted real UUID still fails, and extend the test to prove it.
The Space and build-minute limits now answer quota_exceeded, and the daily publish allowance only warns. Update the authored pages that still named the retired codes.
Refreshed public references
Re-export the complete producer-owned snapshot for CLI/API 0.8.0 rather than editing generated files individually:
The snapshot contains 853 owned artifacts. Existing authored quota-error corrections are retained, and the branch is synced with current documentation.
Compatibility routing
The larger reference exceeded the static route budget. Collapse equivalent resource/tag section aliases into wildcard redirects, with exact method aliases ordered first. This preserves the compatibility destinations while reducing the configuration to 1,989 routing rules. A real routing-compiler test covers section anchors and method precedence.
Verification
The final one-description metadata regeneration was rechecked for ownership, prose, and documentation tests after the full build. Matching producer corrections must merge before future trunk regeneration. npm publication remains an independent release-delivery blocker; this PR does not publish packages or activate installers.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Tag
@indentto continue the conversation here.