fix: make TableIdentifier::normalized fallible#59
Open
iajoiner wants to merge 1 commit into
Open
Conversation
1.28.1Bug Fixes
|
tlovell-sxt
reviewed
Sep 17, 2025
iajoiner
force-pushed
the
fix/audit-Q-01
branch
from
bec36f4 to
90738ca
Compare
iajoiner
force-pushed
the
fix/audit-Q-01
branch
from
90738ca to
6a15246
Compare
iajoiner
changed the title
TableIdentifier::normalizedTableIdentifier::normalized fallible
tlovell-sxt
approved these changes
Oct 13, 2025
tlovell-sxt
left a comment
tlovell-sxt
left a comment
Contributor
There was a problem hiding this comment.
I'm approving this as it is, this function will be temporarily unused but we really should use it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This function is infallible now but it can panic.