Skip to content

Keep date-like strings as strings when deserializing #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enhancer13 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Keep date-like strings as strings when deserializing #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions SlackNet.Tests/SerializationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using Newtonsoft.Json;
using NUnit.Framework;
using SlackNet.Events;
using SlackNet.WebApi;

namespace SlackNet.Tests;

Expand Down Expand Up @@ -209,6 +210,29 @@ public void TimeSpan_DeserializedFromHoursAndMinutes()
});
}

[TestCase("2001-02-03")]
[TestCase("2001-02-03T04:05:06")]
[TestCase("2001-02-03T04:05:06Z")]
[TestCase("2001-02-03T04:05:06+07:00")]
public void DateString_DeserializedToStringProperty_Unchanged(string date)
{
var result = Deserialize<Event>($@"{{ ""type"": ""message"", ""text"": ""{date}"" }}");
result.ShouldBeA<MessageEvent>()
.And.Text.ShouldBe(date);
}

[TestCase("2001-02-03")]
[TestCase("2001-02-03T04:05:06+07:00")]
public void DateString_InWebApiResponse_Unchanged(string date)
{
var response = Deserialize<WebApiResponse>($@"{{ ""ok"": true, ""messages"": [{{ ""type"": ""message"", ""text"": ""{date}"" }}] }}");

var result = response.Data.ToObject<ConversationHistoryResponse>(JsonSerializer.Create(_sut));

result.Messages.ShouldBeASingular<MessageEvent>()
.And.Text.ShouldBe(date);
}

private string Serialize(object obj) => JsonConvert.SerializeObject(obj, _sut);

private T Deserialize<T>(string json) => JsonConvert.DeserializeObject<T>(json, _sut);
Expand Down
1 change: 1 addition & 0 deletions SlackNet/Default.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ private static JsonSerializerSettings SerializerSettings(ISlackTypeResolver slac
TraceWriter = new SerializationLogger(logger),
NullValueHandling = NullValueHandling.Ignore,
DateFormatString = "yyyy-MM-dd",
DateParseHandling = DateParseHandling.None,
ContractResolver = new SlackNetContractResolver
{
NamingStrategy = namingStrategy,
Expand Down