Repository navigation
List an OpenAPI description among the resources of the catalog - #1336
Merged
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummaryPR summary
🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
1 issue found across 22 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/search/include/sourcemeta/one/search.h">
<violation number="1" location="src/search/include/sourcemeta/one/search.h:69">
P3: This comment is the public contract for search results, but it omits that search only returns schema entries now. Add that sentence here, since OpenAPI entries are filtered out in `search.cc`.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Comment on lines
+69
to
+70
| // metadata, then healthier ones. The scope only narrows which fields are | ||
| // searched |
There was a problem hiding this comment.
P3: This comment is the public contract for search results, but it omits that search only returns schema entries now. Add that sentence here, since OpenAPI entries are filtered out in search.cc.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At src/search/include/sourcemeta/one/search.h, line 69:
<comment>This comment is the public contract for search results, but it omits that search only returns schema entries now. Add that sentence here, since OpenAPI entries are filtered out in `search.cc`.</comment>
<file context>
@@ -56,12 +59,15 @@ struct SearchRecordHeader {
+// The catalog holds one kind after the other, the way a directory lists what
+// it holds, and ranks within a kind. Ranking is fixed and intentionally not
+// configurable: higher-priority entries come first, then entries with richer
+// metadata, then healthier ones. The scope only narrows which fields are
+// searched
inline constexpr std::uint8_t SEARCH_SCOPE_PATH{0b001};
</file context>
Suggested change
| // metadata, then healthier ones. The scope only narrows which fields are | |
| // searched | |
| // metadata, then healthier ones. The scope only narrows which fields are | |
| // searched, and search only returns schema entries, skipping OpenAPI ones |
Contributor
There was a problem hiding this comment.
Benchmark (community)
Details
| Benchmark suite | Current: 232494f | Previous: 4735f13 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
325 ms |
196 ms |
1.66 |
Add one schema (100 existing) |
45 ms |
32 ms |
1.41 |
Add one schema (1000 existing) |
91 ms |
100 ms |
0.91 |
Add one schema (10000 existing) |
655 ms |
736 ms |
0.89 |
Update one schema (1 existing) |
38 ms |
27 ms |
1.41 |
Update one schema (101 existing) |
45 ms |
32 ms |
1.41 |
Update one schema (1001 existing) |
96 ms |
174 ms |
0.55 |
Update one schema (10001 existing) |
683 ms |
682 ms |
1.00 |
Cached rebuild (1 existing) |
12 ms |
11 ms |
1.09 |
Cached rebuild (101 existing) |
19 ms |
14 ms |
1.36 |
Cached rebuild (1001 existing) |
41 ms |
34 ms |
1.21 |
Cached rebuild (10001 existing) |
287 ms |
247 ms |
1.16 |
Index 100 schemas |
401 ms |
324 ms |
1.24 |
Index 1000 schemas |
1342 ms |
907 ms |
1.48 |
Index 10000 schemas |
12245 ms |
9102 ms |
1.35 |
Index 10000 schemas (custom meta-schema) |
16419 ms |
11577 ms |
1.42 |
Index 10000 schemas ($ref fan-out) |
14558 ms |
10870 ms |
1.34 |
test/e2e/html: Schema Fetch (p50) |
392 us |
213 us |
1.84 |
test/e2e/html: Schema Fetch (p99) |
480 us |
272 us |
1.76 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark (enterprise)
Details
| Benchmark suite | Current: 232494f | Previous: 4735f13 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
353 ms |
574 ms |
0.61 |
Add one schema (100 existing) |
89 ms |
120 ms |
0.74 |
Add one schema (1000 existing) |
143 ms |
170 ms |
0.84 |
Add one schema (10000 existing) |
868 ms |
785 ms |
1.11 |
Update one schema (1 existing) |
79 ms |
110 ms |
0.72 |
Update one schema (101 existing) |
88 ms |
124 ms |
0.71 |
Update one schema (1001 existing) |
145 ms |
175 ms |
0.83 |
Update one schema (10001 existing) |
857 ms |
804 ms |
1.07 |
Cached rebuild (1 existing) |
12 ms |
13 ms |
0.92 |
Cached rebuild (101 existing) |
14 ms |
16 ms |
0.88 |
Cached rebuild (1001 existing) |
40 ms |
42 ms |
0.95 |
Cached rebuild (10001 existing) |
287 ms |
318 ms |
0.90 |
Index 100 schemas |
569 ms |
764 ms |
0.74 |
Index 1000 schemas |
1437 ms |
2070 ms |
0.69 |
Index 10000 schemas |
11770 ms |
16366 ms |
0.72 |
Index 10000 schemas (custom meta-schema) |
11825 ms |
16773 ms |
0.71 |
Index 10000 schemas ($ref fan-out) |
14689 ms |
22358 ms |
0.66 |
enterprise/e2e/auth: Schema Anonymous (p50) |
230 us |
386 us |
0.60 |
enterprise/e2e/auth: Schema Anonymous (p99) |
702 us |
494 us |
1.42 |
enterprise/e2e/auth: Schema API Key Identity (p50) |
230 us |
390 us |
0.59 |
enterprise/e2e/auth: Schema API Key Identity (p99) |
582 us |
496 us |
1.17 |
enterprise/e2e/auth: Schema API Key SHA256 (p50) |
239 us |
397 us |
0.60 |
enterprise/e2e/auth: Schema API Key SHA256 (p99) |
1032 us |
501 us |
2.06 |
enterprise/e2e/auth: Schema JWT (p50) |
327 us |
517 us |
0.63 |
enterprise/e2e/auth: Schema JWT (p99) |
844 us |
673 us |
1.25 |
test/e2e/html: Schema Fetch (p50) |
229 us |
390 us |
0.59 |
test/e2e/html: Schema Fetch (p99) |
328 us |
482 us |
0.68 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com