Skip to content

Render the directory lock on every private entry - #1215

Open
jviotti wants to merge 4 commits into
mainfrom
lock-directory
Open

Render the directory lock on every private entry#1215
jviotti wants to merge 4 commits into
mainfrom
lock-directory

Conversation

@jviotti

@jviotti jviotti commented Aug 13, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode

augmentcode Bot commented Aug 13, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR changes directory icons to represent whether an entry is policy-governed.

Changes:

  • Replaces the previous parent/child policy-difference check with a non-empty entry-policy check.
  • Renders a lock for every private directory, including descendants of a gated root.
  • Retains normal folder and GitHub-avatar rendering for public directories.
  • Adds an auth-keys Hurl suite covering anonymous, vault-key, and ledger-key views.
  • Extends the auth-keys fixture with a second independent API-key policy.
  • Adds nested public and private schemas to exercise directory depth.
  • Updates existing authenticated directory HTML assertions for repeated locks.
Technical notes: The UI now relies on the indexed listing contract: an empty policies array denotes a public entry, while any populated array denotes a gated entry.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Re-trigger cubic

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: f3c4b73 Previous: 3b18928 Ratio
Add one schema (0 existing) 338 ms 318 ms 1.06
Add one schema (100 existing) 34 ms 32 ms 1.06
Add one schema (1000 existing) 103 ms 101 ms 1.02
Add one schema (10000 existing) 932 ms 980 ms 0.95
Update one schema (1 existing) 26 ms 24 ms 1.08
Update one schema (101 existing) 35 ms 33 ms 1.06
Update one schema (1001 existing) 104 ms 101 ms 1.03
Update one schema (10001 existing) 862 ms 850 ms 1.01
Cached rebuild (1 existing) 8 ms 8 ms 1
Cached rebuild (101 existing) 11 ms 11 ms 1
Cached rebuild (1001 existing) 39 ms 41 ms 0.95
Cached rebuild (10001 existing) 345 ms 360 ms 0.96
Index 100 schemas 665 ms 587 ms 1.13
Index 1000 schemas 1562 ms 1423 ms 1.10
Index 10000 schemas 13842 ms 13182 ms 1.05
Index 10000 schemas (custom meta-schema) 16968 ms 15786 ms 1.07
Index 10000 schemas ($ref fan-out) 16817 ms 15761 ms 1.07

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: f3c4b73 Previous: 3b18928 Ratio
Add one schema (0 existing) 425 ms 387 ms 1.10
Add one schema (100 existing) 107 ms 117 ms 0.91
Add one schema (1000 existing) 166 ms 186 ms 0.89
Add one schema (10000 existing) 832 ms 897 ms 0.93
Update one schema (1 existing) 99 ms 108 ms 0.92
Update one schema (101 existing) 106 ms 116 ms 0.91
Update one schema (1001 existing) 168 ms 185 ms 0.91
Update one schema (10001 existing) 849 ms 910 ms 0.93
Cached rebuild (1 existing) 9 ms 10 ms 0.90
Cached rebuild (101 existing) 12 ms 13 ms 0.92
Cached rebuild (1001 existing) 38 ms 44 ms 0.86
Cached rebuild (10001 existing) 330 ms 366 ms 0.90
Index 100 schemas 514 ms 697 ms 0.74
Index 1000 schemas 1552 ms 1528 ms 1.02
Index 10000 schemas 13258 ms 13226 ms 1.00
Index 10000 schemas (custom meta-schema) 16128 ms 15915 ms 1.01
Index 10000 schemas ($ref fan-out) 15996 ms 16221 ms 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread enterprise/e2e/auth-keys/hurl/lock.all.hurl
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant