Stop producing the dead 401 HTML page - #1214
Merged
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
|
This pull request is abnormally large and would use a significant amount of tokens to review. If you still wish to review it, comment "augment review" and we will review it. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 44 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 9e4e2fd | Previous: 86ab0d5 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
339 ms |
314 ms |
1.08 |
Add one schema (100 existing) |
34 ms |
32 ms |
1.06 |
Add one schema (1000 existing) |
102 ms |
102 ms |
1 |
Add one schema (10000 existing) |
865 ms |
1182 ms |
0.73 |
Update one schema (1 existing) |
25 ms |
25 ms |
1 |
Update one schema (101 existing) |
36 ms |
33 ms |
1.09 |
Update one schema (1001 existing) |
106 ms |
102 ms |
1.04 |
Update one schema (10001 existing) |
873 ms |
857 ms |
1.02 |
Cached rebuild (1 existing) |
8 ms |
8 ms |
1 |
Cached rebuild (101 existing) |
11 ms |
11 ms |
1 |
Cached rebuild (1001 existing) |
39 ms |
41 ms |
0.95 |
Cached rebuild (10001 existing) |
336 ms |
381 ms |
0.88 |
Index 100 schemas |
677 ms |
618 ms |
1.10 |
Index 1000 schemas |
1576 ms |
1476 ms |
1.07 |
Index 10000 schemas |
14955 ms |
13123 ms |
1.14 |
Index 10000 schemas (custom meta-schema) |
17256 ms |
16261 ms |
1.06 |
Index 10000 schemas ($ref fan-out) |
16592 ms |
16037 ms |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 9e4e2fd | Previous: 86ab0d5 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
402 ms |
399 ms |
1.01 |
Add one schema (100 existing) |
145 ms |
117 ms |
1.24 |
Add one schema (1000 existing) |
125 ms |
182 ms |
0.69 |
Add one schema (10000 existing) |
1485 ms |
878 ms |
1.69 |
Update one schema (1 existing) |
73 ms |
107 ms |
0.68 |
Update one schema (101 existing) |
224 ms |
114 ms |
1.96 |
Update one schema (1001 existing) |
264 ms |
180 ms |
1.47 |
Update one schema (10001 existing) |
948 ms |
887 ms |
1.07 |
Cached rebuild (1 existing) |
5 ms |
10 ms |
0.50 |
Cached rebuild (101 existing) |
7 ms |
13 ms |
0.54 |
Cached rebuild (1001 existing) |
23 ms |
42 ms |
0.55 |
Cached rebuild (10001 existing) |
222 ms |
361 ms |
0.61 |
Index 100 schemas |
588 ms |
659 ms |
0.89 |
Index 1000 schemas |
1181 ms |
1492 ms |
0.79 |
Index 10000 schemas |
16161 ms |
13126 ms |
1.23 |
Index 10000 schemas (custom meta-schema) |
14479 ms |
15661 ms |
0.92 |
Index 10000 schemas ($ref fan-out) |
17592 ms |
15846 ms |
1.11 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com