Skip to content

Render login/logout buttons on the nav bar - #1213

Merged
jviotti merged 2 commits into
mainfrom
chrome-login-logout
Aug 13, 2026
Merged

Render login/logout buttons on the nav bar#1213
jviotti merged 2 commits into
mainfrom
chrome-login-logout

Conversation

@jviotti

@jviotti jviotti commented Aug 13, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode

augmentcode Bot commented Aug 13, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR adds session-aware sign-in and sign-out controls to the web explorer navigation bar.

Changes:

  • Build actions now carry the named authentication view used to render each explorer artifact.
  • Explorer pages and HTML error pages pass that view into shared navigation generation.
  • Anonymous views display a Sign In link only when an OIDC policy exists.
  • OIDC-authenticated views display a POST-backed Sign Out control; machine-key views display neither control.
  • The login page continues to be a dedicated provider-selection page without explorer navigation.
  • Build-plan view metadata changed from positional indices to stable view-name strings.
  • Added an API-key-only E2E sandbox and expanded Hurl/Playwright coverage for public, OIDC, key, and 404 views.
  • CI and Makefile targets now execute the new native and containerized authentication-key checks.
  • Documentation explains the new non-redirecting, navigation-based OIDC entry and exit behavior.
Technical Notes: Controls are rendered into separately built per-view HTML artifacts, preserving cache and authorization boundaries.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 30 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/web/CMakeLists.txt Outdated
Comment thread enterprise/e2e/auth-keys/compose.yml Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 821bafc Previous: 2054df5 Ratio
Add one schema (0 existing) 342 ms 384 ms 0.89
Add one schema (100 existing) 32 ms 35 ms 0.91
Add one schema (1000 existing) 104 ms 104 ms 1
Add one schema (10000 existing) 848 ms 878 ms 0.97
Update one schema (1 existing) 24 ms 26 ms 0.92
Update one schema (101 existing) 34 ms 35 ms 0.97
Update one schema (1001 existing) 101 ms 106 ms 0.95
Update one schema (10001 existing) 812 ms 883 ms 0.92
Cached rebuild (1 existing) 8 ms 8 ms 1
Cached rebuild (101 existing) 11 ms 11 ms 1
Cached rebuild (1001 existing) 39 ms 39 ms 1
Cached rebuild (10001 existing) 328 ms 346 ms 0.95
Index 100 schemas 646 ms 654 ms 0.99
Index 1000 schemas 1581 ms 1575 ms 1.00
Index 10000 schemas 13748 ms 14144 ms 0.97
Index 10000 schemas (custom meta-schema) 16617 ms 16860 ms 0.99
Index 10000 schemas ($ref fan-out) 16604 ms 17123 ms 0.97

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 821bafc Previous: 2054df5 Ratio
Add one schema (0 existing) 401 ms 367 ms 1.09
Add one schema (100 existing) 102 ms 100 ms 1.02
Add one schema (1000 existing) 160 ms 164 ms 0.98
Add one schema (10000 existing) 794 ms 919 ms 0.86
Update one schema (1 existing) 92 ms 95 ms 0.97
Update one schema (101 existing) 100 ms 100 ms 1
Update one schema (1001 existing) 158 ms 158 ms 1
Update one schema (10001 existing) 826 ms 930 ms 0.89
Cached rebuild (1 existing) 8 ms 7 ms 1.14
Cached rebuild (101 existing) 11 ms 8 ms 1.38
Cached rebuild (1001 existing) 38 ms 26 ms 1.46
Cached rebuild (10001 existing) 316 ms 224 ms 1.41
Index 100 schemas 487 ms 598 ms 0.81
Index 1000 schemas 1533 ms 1272 ms 1.21
Index 10000 schemas 13155 ms 11597 ms 1.13
Index 10000 schemas (custom meta-schema) 15923 ms 16113 ms 0.99
Index 10000 schemas ($ref fan-out) 15896 ms 14332 ms 1.11

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti
jviotti merged commit 86ab0d5 into main Aug 13, 2026
6 checks passed
@jviotti
jviotti deleted the chrome-login-logout branch August 13, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant