Skip to content

Do a pass removing duplicate tests and strengthening weak ones - #821

Merged
jviotti merged 2 commits into
mainfrom
tests-cleanup
Aug 12, 2026
Merged

Do a pass removing duplicate tests and strengthening weak ones#821
jviotti merged 2 commits into
mainfrom
tests-cleanup

Conversation

@jviotti

@jviotti jviotti commented Aug 12, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode

augmentcode Bot commented Aug 12, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR removes redundant CLI tests and strengthens tests that previously asserted little beyond exit status.

Changes:

  • Removes duplicate TypeScript codegen and verbose test-description coverage.
  • Renames CI HTTP failures to distinguish non-JSON responses from valid JSON that is not a schema.
  • Validates that a bundled document is formatted, parseable JSON after extracting its output.
  • Exercises compiled patternProperties with matching valid and invalid instance properties, including JSON diagnostics.
  • Makes dialect-option precedence observable through a Draft 6 const schema.
  • Verifies failed lint fixes do not modify individual schemas or any files in a directory.
  • Expands lint fixtures so top-level scope and built-in-rule interactions are observable.

Technical Notes: The changes primarily improve regression-test signal without modifying production behavior.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 15 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread test/lint/fail_lint_rule_violation.clitest
Comment thread test/compile/pass_patternproperties.clitest
Comment thread test/lint/pass_lint_rule_no_violation.clitest Outdated
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti
jviotti merged commit 183804a into main Aug 12, 2026
16 checks passed
@jviotti
jviotti deleted the tests-cleanup branch August 12, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant