Skip to content

Fix validate --benchmark printing errors twice - #820

Merged
jviotti merged 1 commit into
mainfrom
benchmark-error-twice
Aug 12, 2026
Merged

Fix validate --benchmark printing errors twice#820
jviotti merged 1 commit into
mainfrom
benchmark-error-twice

Conversation

@jviotti

@jviotti jviotti commented Aug 12, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode

augmentcode Bot commented Aug 12, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Removes the redundant manually buffered schema-validation error from both validate --benchmark execution paths.

Changes: The command now relies on the existing validation-output formatter for the single diagnostic, and the benchmark failure CLI test expectation is updated accordingly.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@jviotti
jviotti merged commit e35ae04 into main Aug 12, 2026
16 checks passed
@jviotti
jviotti deleted the benchmark-error-twice branch August 12, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant