Match configuration resolve keys by canonical URI

[jviotti]

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

[augmentcode]

🤖 Augment PR Summary

Summary: This PR tightens and consolidates CLI test coverage while fixing two behaviors.

Changes:

• Removes duplicate schema-validation errors emitted during benchmark failures.
• Allows configuration resolve keys written with an empty URI fragment to match fragment-stripped identifiers.
• Adds an install test covering an empty-fragment resolve mapping and lockfile output.
• Strengthens bundle, compile, lint, and codegen tests so their fixtures exercise the intended behavior.
• Verifies failed lint fixes leave individual schemas and recursive directory inputs unchanged.
• Makes help-output assertions version-independent via the $VERSION placeholder.
• Renames CI HTTP tests to describe non-JSON responses more accurately.
• Removes redundant or non-observable tests and updates CMake registrations accordingly.

Technical Notes: The resolver retains its existing exact and .json fallback behavior, with added empty-fragment lookup handling.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

find_resolve_match applies the .json aliases before normalizing an empty fragment. Consequently, a mapping such as https://example.com/types/name.json# will not resolve a reference to https://example.com/types/name, although the equivalent key without # does; this means an empty-fragment mapping does not fully behave like the same mapping without the fragment.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[cubic-dev-ai]

All reported issues were addressed across 22 files

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

All reported issues were addressed across 3 files (changes from recent commits).

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

2 issues found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/resolver.h">

<violation number="1" location="src/resolver.h:45">
P1: When a configuration contains canonical-equivalent `resolve` keys, `canonical_resolve_map` silently keeps one mapping, so the other spelling can resolve to the wrong schema. Preserve exact-key precedence or retain all entries that share a canonical key.</violation>

<violation number="2" location="src/resolver.h:87">
P2: Every `resolve_map_uri(configuration, ...)` call rebuilds and canonicalizes the full map. `command_install.cc:57` uses this overload for each dependency resolution, so large installs pay repeated allocations; reuse a cached canonical map.</violation>
</file>

<sub>Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic</sub>

[cubic-dev-ai]

P1: When a configuration contains canonical-equivalent resolve keys, canonical_resolve_map silently keeps one mapping, so the other spelling can resolve to the wrong schema. Preserve exact-key precedence or retain all entries that share a canonical key.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/resolver.h, line 45:

<comment>When a configuration contains canonical-equivalent `resolve` keys, `canonical_resolve_map` silently keeps one mapping, so the other spelling can resolve to the wrong schema. Preserve exact-key precedence or retain all entries that share a canonical key.</comment>

<file context>
@@ -34,44 +34,58 @@ namespace sourcemeta::jsonschema {
+  std::unordered_map<std::string, std::string> result;
+  result.reserve(resolve_map.size());
+  for (const auto &entry : resolve_map) {
+    result.emplace(sourcemeta::core::URI::canonicalize(entry.first),
+                   entry.second);
+  }
</file context>

[cubic-dev-ai]

P2: Every resolve_map_uri(configuration, ...) call rebuilds and canonicalizes the full map. command_install.cc:57 uses this overload for each dependency resolution, so large installs pay repeated allocations; reuse a cached canonical map.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/resolver.h, line 87:

<comment>Every `resolve_map_uri(configuration, ...)` call rebuilds and canonicalizes the full map. `command_install.cc:57` uses this overload for each dependency resolution, so large installs pay repeated allocations; reuse a cached canonical map.</comment>

<file context>
@@ -34,44 +34,58 @@ namespace sourcemeta::jsonschema {
+static inline auto
+resolve_map_uri(const sourcemeta::blaze::Configuration &configuration,
+                const std::string &identifier) -> std::optional<std::string> {
+  return resolve_map_uri(canonical_resolve_map(configuration.resolve),
+                         configuration.base_path, identifier);
 }
</file context>