fix(query): parse field filters inside parentheses#1080
Open
jojosenthusiast wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1074
Reproduction
(sym:foo)was parsed as a literal substring query forsym:fooinstead of a grouped symbol filter.( sym:foo)already parsed as a symbol filter.Fix summary
sym:andf:field filters.Tests run
git diff --check→ passgo test ./query/ -run TestParseQuery -count=1→ passgo test ./query -count=1→ passgo test ./... -short→ fails locally on Windows/environment issues unrelated toquery(unix.Umask/platform build errors, missingfalse, Windows path expectations, struct-size assumptions, allocator memory reserve). The changedquerypackage stayed green.Risk
Low. The change is limited to tokenization before known field prefixes inside parentheses; non-field parenthesized text keeps the existing literal behavior.
Non-goals