Repository navigation
OSS-24153 | Fixed type annotations in assignments not creating symbols - #162
Merged
Merged
Conversation
varungandhi-src
left a comment
varungandhi-src
left a comment
Contributor
There was a problem hiding this comment.
I haven't had the time to look into this fully, so could you elaborate on:
- Is this meant as a full fix for the underlying bug?
- Is the 'TODO' meant for yourself or meant to be merged?
Additionally, could you add some tests covering different cases?
Changes the method lookup logic to use the same logic as Pyright internals instead of our own ad-hoc implementation of name resolution, which does not match Python's method resolution order (MRO), which is based purely on names, and not on types. This gets rid of a code path where we were doing a `!` operation, which triggered a crash when indexing a prospect's codebase. Fixes GRAPH-1278.
chrapkowski-sg
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix information and identity for name-based annotated variables, including annotations without an initializer.
Use the same canonical declaration symbol for annotation metadata and definition/reference occurrences. Do not treat an annotation as another scope or allocate a disconnected local symbol. Share information deduplication with ordinary assignments so an annotation following an assignment does not add duplicate or orphan records.
Scope
This is a narrow annotation fix, addressing the earlier review request to clarify completeness and add coverage. It covers module/class/function/method variables, including prior assignments. It is not a redesign of member or constructor resolution.
The accumulated constructor heuristics, unrelated evaluator changes, Docker/scripts/generated changes, and already-landed casing/MRO work are excluded. Inherited methods continue to resolve through their declarations rather than being fabricated on the constructor's class.
Verification
Child().method()to the definingBase#method()..