Expose sentinel error for reversing Git copies - #93
Merged
Conversation
Callers need a stable way to distinguish the valid-but-unsupported Git copy case from other reversal failures. Exposing and returning a sentinel preserves the existing behavior while making that condition programmatically detectable. Amp-Thread-ID: https://ampcode.com/threads/T-01a08a2d-a5f9-726c-bf53-aab80421f8ef Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a narrow follow-up to #92. Git copy diffs are valid input but cannot be reversed because they lack enough information to delete the copied file.
ReverseFileDiffnow returns the exportedErrCannotReverseCopysentinel for that case, allowing callers to distinguish it from other failures by direct equality (and therefore witherrors.Isas well) without changing the existing error text or reversal behavior.The focused copy-diff test now verifies the sentinel identity. Validation passed with
go test -race ./...,go vet ./..., andgit diff --check.