fix(web): prevent workspace connector focus ring clipping

[brendan-kellam]

Summary

• reserve horizontal space for focus rings inside scrollable workspace connector dialogs
• preserve the existing constrained-height scrolling behavior

Testing

• yarn workspace @sourcebot/web test --run "src/app/(app)/settings/workspaceAskAgent/workspaceAskAgentPage.test.tsx"
• yarn workspace @sourcebot/web lint (passes with 4 pre-existing warnings)

---

Note

Low Risk
CSS-only spacing tweak in workspace settings dialogs; no auth, API, or data-path changes.

Overview
Fixes focus rings being clipped in scrollable workspace connector dialogs on the Ask Sourcebot settings page by adjusting padding on the shared scrollable dialog body class.

scrollableConnectorDialogBodyClassName now uses px-1 instead of pr-1 only, so keyboard focus outlines on inputs and controls inside the overflow-scrolling area have horizontal room and stay visible. Constrained-height scrolling behavior is unchanged.

Documents the fix under Unreleased → Fixed in CHANGELOG.md.

^{Reviewed by Cursor Bugbot for commit 52afedd. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• Bug Fixes
  • Improved focus ring visibility in workspace connector dialogs by preventing them from being clipped.
  • Updated connector dialog spacing by adjusting horizontal padding for the scrollable dialog body to feel more consistent.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e06ee445-f3a2-46a6-84dc-b310473d7887

📥 Commits

Reviewing files that changed from the base of the PR and between 674207c and 52afedd.

📒 Files selected for processing (1)

• CHANGELOG.md

---

Walkthrough

The connector dialog body now uses horizontal padding to prevent focus rings from being clipped. The unreleased changelog records this fix.

Changes

Connector dialog styling

Layer / File(s)	Summary
Scrollable dialog padding update packages/web/src/app/(app)/settings/workspaceAskAgent/workspaceAskAgentPage.tsx, CHANGELOG.md	The dialog body changes from right-only to horizontal padding, and the focus-ring clipping fix is documented.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• sourcebot-dev/sourcebot#1418: Modifies the same connector dialog body styling for a related scrolling and layout fix.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main fix: preventing focus ring clipping in workspace connector dialogs.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch brendan/fix-workspace-ask-agent-focus-rings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}