Repository navigation
Use the prebuilt x64 protoc on Windows ARM64 and release 0.3.4. - #2
Merged
Merged
Conversation
protobuf publishes no Windows ARM64 protoc, so on that exec platform the proto toolchain matched no prebuilt and Bazel compiled protoc, abseil, and upb from source. bazel_utils_buf now registers a toolchain for Windows ARM64 that uses protoc-36.2-win64.zip (Windows 11 on ARM emulates it), and protoc_prefix fails instead of staging a protoc compiled from source. The sha256 equals the protobuf module's own win64 pin and the zip was downloaded and checked against it. Cross-analysis with a Windows ARM64 exec platform selects the new toolchain; without it the from-source protoc is selected. Raised every module to 0.3.4. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Aleksandr Sokolovskii <amsokol@gmail.com>
…st bash. The Windows CI job runs without a host bash, and protoc_prefix used ctx.actions.run_shell, so //tests/buf:protoc_prefix failed there. The rule now takes SHELL_ACTION_ATTRS and runs the script with busybox on Windows, and stages bin/protoc.exe next to bin/protoc when the compiler is an .exe. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Aleksandr Sokolovskii <amsokol@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
protobuf publishes no Windows ARM64
protoc, so Bazel compiled protoc, abseil, and upb from source on that exec platform.bazel_utils_bufnow registers a toolchain for it that usesprotoc-36.2-win64.zip(emulated on Windows 11 ARM), andprotoc_prefixfails on a from-source protoc.//tests/buf:protoc_prefixbuilds it on every CI platform.🤖 Generated with Claude Code