Version Packages (next) - #1049
Merged
Merged
Conversation
Deploying solid-primitives with
|
| Latest commit: |
872624e
|
| Status: | ⚡️ Build in progress... |
✅ Deploy Preview for solid-primitives-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.
nextis currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, runchangeset pre exitonnext.Releases
@solid-primitives/form@1.0.0-next.3
Patch Changes
1c687d9: Fix
createForm's defaultvalidateOn: "change"mode showing a field's error immediately on mount, before the user had touched it.error()was wired directly to the raw, ungated validation result for"change"mode, so any field whose initial value failed validation (e.g. a required field starting empty) rendered errored from the first paint."change"mode's validator error is now gated on per-field dirtiness (value() !== initial) — hidden until the field's value actually changes, and hidden again if it's changed back to the initial value.blur/submitmodes are unaffected (still gated ontouched()/submitted()respectively).Fixing this also surfaced a second, separate bug: the gating was applied to the combined raw error, which included any
setError()-injected external error (e.g. a server-side validation message) — so an external error set on a pristine"change"-mode field was incorrectly hidden too. External errors are now always shown immediately regardless of mode/dirty/touched/submitted state, matching their documented purpose (setError: "Inject an external error (e.g. from a server response)").form.errors()andform.valid()are unaffected either way — both were already, and remain, ungated (true validity regardless of display timing).