fix: load canvas fonts also when using webgl renderer#29
Closed
CosmaVergari wants to merge 1 commit into
Closed
Conversation
Contributor
|
Why? We're only using SDF OR Canvas, not both. What is the use case for loading both sets of fonts? |
Author
This PR is for adding the capability of using Canvas fonts on the WebGL renderer. As of now that check prevents loading Canvas fonts when the WebGL renderer is used. |
Contributor
|
Fixed with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment on the renderer side the canvas text renderer is created but the fonts are not loaded, so renderText does not work.
Solution : allow the loading of canvas fonts when using any non-dom renderer