Skip to content

Migrate avoid unnecessary set state rule and its tests#238

Open
daria-trusca-solid wants to merge 6 commits into
analysis_server_migrationfrom
migrate_avoid_unnecessary_set_state
Open

Migrate avoid unnecessary set state rule and its tests#238
daria-trusca-solid wants to merge 6 commits into
analysis_server_migrationfrom
migrate_avoid_unnecessary_set_state

Conversation

@daria-trusca-solid
Copy link
Copy Markdown
Collaborator

Migrated the avoid_unnecessary_set_state rule and its corresponding tests to comply with the analyzer package.

Changes

  • Rule Refactoring: Updated the implementation of avoid_unnecessary_set_state to use the current analyzer syntax.
  • Tests: Updated and verified all associated test cases to ensure the rule triggers correctly and no regressions are introduced.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the AvoidUnnecessarySetStateRule to extend AnalysisRule instead of SolidLintRule, updating its implementation to use the new analyzer APIs. The associated AvoidUnnecessarySetStateVisitor has been updated to extend SimpleAstVisitor and handle diagnostics reporting directly. Additionally, the PR removes an old test file and introduces a comprehensive unit test suite using AnalysisRuleTest. There are no review comments, so no feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant