Migrate avoid unnecessary set state rule and its tests#238
Migrate avoid unnecessary set state rule and its tests#238daria-trusca-solid wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the AvoidUnnecessarySetStateRule to extend AnalysisRule instead of SolidLintRule, updating its implementation to use the new analyzer APIs. The associated AvoidUnnecessarySetStateVisitor has been updated to extend SimpleAstVisitor and handle diagnostics reporting directly. Additionally, the PR removes an old test file and introduces a comprehensive unit test suite using AnalysisRuleTest. There are no review comments, so no feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Migrated the
avoid_unnecessary_set_staterule and its corresponding tests to comply with theanalyzerpackage.Changes
avoid_unnecessary_set_stateto use the current analyzer syntax.