Repository navigation
Remove stale cargo audit ignores - #382
Closed
lorisleiva wants to merge 1 commit into
Closed
lorisleiva wants to merge 1 commit into
lorisleiva wants to merge 1 commit into
Conversation
This PR removes the three `--ignore` flags from `make audit`, since none of those advisories fire any more. Keeping them would not save us future work. Because `Cargo.lock` is checked in, an advisory only comes back if we reintroduce a vulnerable version, for example through a downgrade or a new dependency pulling in an older major line. When that happens we want CI to flag it, rather than have a stale ignore quietly let it through. If one does come back and can't be bumped, we can re-add the ignore with a comment explaining why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the three
--ignoreflags frommake audit, since none of those advisories fire any more. Keeping them would not save us future work. BecauseCargo.lockis checked in, an advisory only comes back if we reintroduce a vulnerable version, for example through a downgrade or a new dependency pulling in an older major line. When that happens we want CI to flag it, rather than have a stale ignore quietly let it through. If one does come back and can't be bumped, we can re-add the ignore with a comment explaining why.