Fix flaky CircuitBreakerTest timing assertions#452
Merged
Conversation
Replace shared eventually timeout/interval vals with concrete values sized to each test's config: the transient HalfOpen catch uses a timeout inside the half-open window, while the recovery-to-Open wait outlasts it. Widen the half-open window so the transient state is reliably sampled under load. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI run 26810641361 failed on the
ci (21)matrix entry inox.resilience.CircuitBreakerTest(CircuitBreakerTest.scala:153, test "should switch back to open after configured timeout in half open state").Root cause
The scheduled circuit-breaker state transitions (open → half-open → open) are driven by forked timers handed off to the breaker's actor. The exact moment a transition becomes observable depends on thread scheduling, so on a loaded CI runner a transition can land later than its nominal delay. The tests asserted state with a single fixed
sleep-then-read, which is racy — hence the intermittent failure.Fix
Replace the fixed-
sleep-then-read assertions with ScalaTestEventuallypolling (8s timeout, 50ms interval) for the expected state. This keeps the assertions deterministic in intent while tolerating scheduling jitter. No production code changed.🤖 Generated with Claude Code