Add more complex transformations example#3124
Open
j-piasecki wants to merge 4 commits into
Open
Conversation
8b20d90 to
7172bbf
Compare
Member
Author
|
The V3 coordinates are wrong (at least on iOS). Changing render to fixes it so it seems like the wrong coordinate space is being used. This needs to be investigated. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new, more advanced “Transformations” example to the New API example set (extracted from #2919) and updates the legacy v2 transformations example to use the same matrix-based approach for pan/pinch/rotate composition.
Changes:
- Register a new “Transformations” entry in the New API “Complicated” examples list.
- Add a new New API transformations example that composes pan/pinch/rotation/double-tap using a 4×4 matrix accumulator.
- Rework the legacy v2 transformations example to use the same matrix/origin approach (instead of simple translate/scale/rotate values).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| apps/common-app/src/new_api/index.tsx | Adds the Transformations example to the New API list. |
| apps/common-app/src/new_api/complicated/transformations/index.tsx | New complex matrix-based transformations example using hook gestures. |
| apps/common-app/src/legacy/v2_api/transformations/index.tsx | Updates legacy example to match the complex matrix/origin approach and add layout sizing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
j-piasecki
added a commit
that referenced
this pull request
May 4, 2026
## Description Currently, all native handlers are using the coordinate space of the view they are attached to for calculating events. If the handler is attached directly to the view (v1, v2, intercepting detector), this is correct, but when the handler is attached to a wrapper (native detector), the coordinates may drift if the child is transformed. This PR addresses this by using the child of the native detector as the coordinate space base. ## Test plan Tested on #3124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracted new transformations example from #2919, so that the entire thing isn't blocked by #2929