perf(js): memoize sharedProps in EnrichedMarkdownText#496
Open
hryhoriiK97 wants to merge 2 commits into
Open
Conversation
The sharedProps object passed to the native component was recreated on every render, forcing native prop diffing even when no values changed. Wrap it in useMemo with precise dependencies so parent re-renders that don't change any markdown-related props skip the native bridge entirely. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce unnecessary React Native native-prop updates by stabilizing the prop references passed from EnrichedMarkdownText to the underlying native components.
Changes:
- Introduces
enableLinkPreviewResolvedto simplify thesharedPropsdependency list. - Wraps the
sharedPropsconstruction inuseMemowith an explicit dependency array.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rest comes from parameter destructuring and gets a new object identity on every render, which invalidated the memo every time. Move rest out of the memoized object and spread it at the JSX render site instead. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sharedPropsobject inuseMemowith precise dependenciesenableLinkPreviewResolvedfor a clean dependency arrayMade with Cursor