fix: reset cached style state in Fabric prepareForRecycle to stop stale-markdown flicker#482
Open
mvanhorn wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
On the Fabric (new architecture) iOS path, recycled
EnrichedMarkdown/EnrichedMarkdownTextviews kept cached style and md4c-flag state from their previous mount, so a recycled view briefly showed stale markdown (a flicker) before the next props update repainted it.prepareForRecyclenow resets the cached style state back to the generated-props baseline, and resets_md4cFlagsfrom that same baseline (not the library default), so a recycled view withmd4cFlags.latexMathdisabled no longer parses$...$as math. Fixes #110.Testing
Change is confined to the iOS
prepareForRecyclereset path on the Fabric renderer. Verified by code inspection that the reset now mirrors the reset_propsbaseline so the subsequentupdatePropsdiff applies the incoming flags correctly. On-device iOS/Android runs and the example app were not exercised in this environment, so the iOS/Android build-and-run checklist items are left unchecked for a maintainer with a simulator to confirm.PR Checklist