Skip to content

fix(android): emit list item markers when parsing input#476

Open
multiplechuks wants to merge 1 commit into
software-mansion:mainfrom
multiplechuks:fix/input-parser-list-item-markers
Open

fix(android): emit list item markers when parsing input#476
multiplechuks wants to merge 1 commit into
software-mansion:mainfrom
multiplechuks:fix/input-parser-list-item-markers

Conversation

@multiplechuks

@multiplechuks multiplechuks commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

What/Why?

  • Added a walkListItems helper.
  • Wired UnorderedList and OrderedList node types into walkNode.
  • Reconstructs list item markers (-, 1., and [x]/[ ] for task items) when walking the AST back into markdown.

InputParser.walkNode did not handle list nodes, so markdown parsing on Android silently dropped list markers. As a result, unordered lists, ordered lists, and task lists were rendered as plain paragraphs, losing their original markdown prefixes. This change preserves the correct markdown syntax when converting the parsed AST back into plain text

Testing

  • Manual testing as shown in the gif below
  • All Maestro E2E tests ran
Before After
after

PR Checklist

  • Code compiles and runs on iOS
  • Code compiles and runs on Android
  • Updated documentation/README if applicable
  • Ran example app to verify changes
  • E2E tests are passing
  • Required E2E tests have been added (if applicable)

NB

No new tests were added. Since this change affects the rendered list output on the input component, a Maestro test may be appropriate if you'd like one. I'm happy to add it if needed

Co-authored-by: Easyxchange Pty Ltd <easyxchange-dev>
@multiplechuks multiplechuks force-pushed the fix/input-parser-list-item-markers branch 2 times, most recently from f98ecf2 to 56e697a Compare July 1, 2026 15:51
@multiplechuks multiplechuks marked this pull request as ready for review July 1, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant