fix(android): emit list item markers when parsing input#476
Open
multiplechuks wants to merge 1 commit into
Open
fix(android): emit list item markers when parsing input#476multiplechuks wants to merge 1 commit into
multiplechuks wants to merge 1 commit into
Conversation
Co-authored-by: Easyxchange Pty Ltd <easyxchange-dev>
f98ecf2 to
56e697a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
InputParser.walkNode did not handle list nodes, so markdown parsing on Android silently dropped list markers. As a result, unordered lists, ordered lists, and task lists were rendered as plain paragraphs, losing their original markdown prefixes. This change preserves the correct markdown syntax when converting the parsed AST back into plain text
Testing
PR Checklist
NB
No new tests were added. Since this change affects the rendered list output on the input component, a Maestro test may be appropriate if you'd like one. I'm happy to add it if needed