Very rough first draft at codegen module - #652
Draft
ratmice wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a (not very pretty) first draft which is mostly just pulling code as-is out of
CTLexerBuilder::build()into smaller, more manageable functions. I don't think anything here is really properly named,codegenat times seems like it's doing more parsing/validation than actual code generation (where it never uses it's self type!)I thought that the splitting of the
CTTokenMapBuilderturned out okay, however it is quite a bit simpler with less moving parts.My thoughts are to try and rename the
LexCodegenstructure to something likeLexCodegenBuilder,and then try see if we can manage to come up with a good
Selftype for the codegen parts.Edit:
I haven't tried to make anything public here yet, aiming for close to verbatim code movement.
I do have an idea of what a second draft might look like, we'll see if it works soon.