Verify environment reviewers during release setup - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub can accept an environment update while silently dropping Secret reviewer teams. Release setup previously reported success even though the requested publishing approval was not configured.
Plan and apply now reject Secret teams before changing settings, with instructions to make the team Visible. After an environment update, apply reads the settings back and verifies reviewer types/IDs and the preserved protections. Reviewer order and duplicate configured identities do not cause unnecessary updates. A mismatch stops setup and directs the administrator to inspect the environment and rerun plan.
Includes regression tests for dropped or unexpected reviewers, a removed reviewer rule, changed protections, and failed verification reads, plus updated setup guidance and an Unreleased note.
Validation:
bundle exec ruby -rfileutils -S bake utopia:project:agent:context:update.