Configure publishing environment reviewers during setup. - #26
Merged
Merged
Conversation
Signed-off-by: Samuel Williams <samuel.williams@shopify.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configure the existing publishing environment's reviewers through
gem:github:setup reviewers=socketry/managersor thereviewerslist inconfig/release.yaml. Setup plan shows the current and desired environment policy; apply resolves user/team IDs and updates the reviewer list while preserving branch restrictions, wait timers, self-review prevention, and administrator bypass.The setting is optional: existing configurations leave environment policy unmanaged. Invalid or empty lists and failed environment/reviewer lookups stop apply before it writes settings. An unchanged reviewer list does not update the environment.
Includes tests, release notes, setup/recovery guidance, regenerated agent context, and
socketry/managersin this repository's release configuration. The live policy takes effect after an administrator runsgem:github:setup:apply; no remote settings were changed while preparing this PR.Validation: full Sus suite passed with 509/509 library lines covered; RuboCop passed; Decode documented 31/31 public definitions. A read-only setup plan against this repository resolved the Managers team and preserved the current environment protections.