Conversation
Contributor
Author
|
Hi @darrachequesne, all automated CI checks have passed successfully. Whenever you have some time to review, let me know if any further tweaks are needed. Thanks! |
darrachequesne
pushed a commit
that referenced
this pull request
Sep 11, 2026
Avoid shell parsing issues when Node.js or project paths contain spaces, such as "C:\Program Files\nodejs\node.exe" on Windows.
Member
|
Merged as 551a3dc. Thanks a lot 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quotes
process.execPathand fixture paths when invoking child processes in test suites acrossengine.io,engine.io-client, andsocket.io-client.Motivation
When tests run on environments where Node.js or the project folder path contains spaces (such as the Windows default
C:\Program Files\nodejs\node.exeor directories with spaces),child_process.exec()fails with'C:\Program' is not recognized as an internal or external command.Quoting the paths fixes this issue and aligns these packages with
packages/socket.io/test/close.ts.Checklist
npm run format:check)engine.io,engine.io-client, andsocket.io-client