Repository navigation
Native types cli integration - #866
Open
stobrien89 wants to merge 2 commits into
Open
stobrien89 wants to merge 2 commits into
stobrien89 wants to merge 2 commits into
Conversation
stobrien89
force-pushed
the
native-types-cli-integration
branch
from
October 24, 2026 17:48
44b38e6 to
58549c6
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Accepted import package names can produce invalid distribution metadata, leaving generated packages unbuildable.
1 open issue
What changed in this PR
Completes the native standalone types CLI pipeline, building on lazy model generation in #863 and advancing the Python generator migration in #797.
Changes:
- Connects types-specific CLI settings to selection, schema generation, and lazy model generation.
- Generates package metadata, initializers, and typing markers, then publishes through the file manifest.
- Adds CLI coverage and updates the versioned output snapshot.
| File | Description |
|---|---|
| scripts/codegen-output-py/generate.py | Generates the snapshot through the CLI. |
| packages/smithy-python/tests/unit/test_selection.py | Updates selection tests for working types generation. |
| packages/smithy-python/tests/unit/test_cli.py | Tests package output, settings, and validation. |
| packages/smithy-python/src/smithy_python/types.py | Assembles complete standalone types packages. |
| packages/smithy-python/src/smithy_python/cli.py | Adds types options and invokes generation. |
| packages/smithy-python/README.md | Documents available types generation. |
| codegen-output-py/types/src/example_types/py.typed | Marks the generated package as typed. |
| codegen-output-py/types/src/example_types/_private/__init__.py | Initializes the private package. |
| codegen-output-py/types/src/example_types/__init__.py | Exposes the generated package version. |
| codegen-output-py/types/README.md | Adds generated package documentation. |
| codegen-output-py/types/pyproject.toml | Adds build metadata and tooling settings. |
| codegen-output-py/types/.smithy-python-manifest.json | Tracks the additional generated files. |
Review effort: Balanced
stobrien89
force-pushed
the
native-types-cli-integration
branch
from
October 24, 2026 18:07
58549c6 to
99e8ee5
Compare
stobrien89
force-pushed
the
native-types-cli-integration
branch
from
October 24, 2026 18:16
99e8ee5 to
91f5e28
Compare
stobrien89
force-pushed
the
native-types-cli-integration
branch
2 times, most recently
from
October 24, 2026 18:39
df06c4c to
c93800f
Compare
stobrien89
marked this pull request as ready for review
October 24, 2026 18:49
stobrien89
force-pushed
the
native-types-cli-integration
branch
from
October 25, 2026 17:38
c93800f to
3a125c1
Compare
stobrien89
force-pushed
the
native-types-cli-integration
branch
from
October 25, 2026 19:04
3a125c1 to
73d6de9
Compare
stobrien89
force-pushed
the
native-types-cli-integration
branch
from
October 25, 2026 23:16
b3bef1e to
5220488
Compare
stobrien89
force-pushed
the
native-types-cli-integration
branch
from
October 26, 2026 12:36
5220488 to
230257e
Compare
kuhe
previously approved these changes
Oct 26, 2026
stobrien89
force-pushed
the
native-types-cli-integration
branch
from
October 27, 2026 14:50
230257e to
cb5f272
Compare
stobrien89
force-pushed
the
native-types-cli-integration
branch
from
October 27, 2026 22:07
cb5f272 to
a1b723e
Compare
stobrien89
force-pushed
the
native-types-cli-integration
branch
from
October 27, 2026 22:59
a1b723e to
a02e67f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Issue #, if available:
#797
Description
Completes the native standalone types pipeline by wiring schema and lazy model generation into
smithy-python generate types.codegen-output-pysnapshot.This PR is stacked on #863.
Follow-up work
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.