Non-Blocking Review Concern: SDK default version (36) and all documentation still say 34 — drift will confuse operators
Source: pre-push whole-codebase review
Location: config/config.conf.template:19
Date: 2026-08-07
What was flagged
The diff bumps the android-setup.sh default from 34 to 36, but every piece of user-facing documentation still says 34: config/config.conf.template, docs/configuration.md, docs/environment-variables.md, SPEC.md, and prep-airdrop.sh (the generated config default at line 116). An operator following the docs will write ANDROID_SDK_VERSION="34" in their config, which overrides the new default and defeats the bump. The template is also the source of truth for generated configs (via prep-airdrop.sh), so any freshly generated config.conf from an existing dev machine will still hardcode 34. Update all five locations to 36, or leave the default at 34 and remove the code change until docs are updated together.
Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh
Non-Blocking Review Concern: SDK default version (36) and all documentation still say 34 — drift will confuse operators
Source: pre-push whole-codebase review
Location:
config/config.conf.template:19Date: 2026-08-07
What was flagged
The diff bumps the android-setup.sh default from 34 to 36, but every piece of user-facing documentation still says 34:
config/config.conf.template,docs/configuration.md,docs/environment-variables.md,SPEC.md, andprep-airdrop.sh(the generated config default at line 116). An operator following the docs will writeANDROID_SDK_VERSION="34"in their config, which overrides the new default and defeats the bump. The template is also the source of truth for generated configs (via prep-airdrop.sh), so any freshly generated config.conf from an existing dev machine will still hardcode 34. Update all five locations to 36, or leave the default at 34 and remove the code change until docs are updated together.Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh