chore: refactor proposal cancel tests

[ecPablo]

This pull request significantly refactors the TestTimelock_Cancel end-to-end test for the Aptos timelock module, making the test more modular, maintainable, and reusable. The refactor replaces a large, monolithic function with a structured approach that leverages shared test hooks and utility functions, reducing duplication and improving clarity.

Key improvements and refactoring:

Test structure and modularization:

• Replaces the previous inline test logic with a call to e2ecommon.RunScheduleAndCancelTest, centralizing the scheduling and cancellation logic and enabling code reuse across tests.
• Extracts repeated setup steps (such as ownership transfer and role configuration) into dedicated helper methods: initTransferOwnership, configureRole, and buildAcceptOwnershipTransaction.

Signer and role management:

• Introduces testutils.MakeNewECDSASigners to generate signers for both proposer and canceller roles, and adds a keysToAddresses utility for address extraction, simplifying signer management and reducing boilerplate. [1] [2]

Flexible test hooks and assertions:

• Implements flexible hooks (e.g., Setup, Sign, DeriveCancellationMetadata, WaitForTransaction, AssertExtraAfterCancel) to allow custom logic at each stage of the test, improving extensibility and clarity of test intent.

Improved readability and maintainability:

• Removes large blocks of repetitive code for proposal creation, signing, execution, and assertion, replacing them with concise, well-named function calls and hooks. [1] [2]
• Ensures all critical assertions (such as owner checks after cancellation) are preserved and clearly expressed in dedicated assertion hooks.

Overall, these changes modernize the test by adopting best practices for modularization and code reuse, making future maintenance and extension much easier.

Most important changes:

Test modularization and reuse:

• Refactored the test to use e2ecommon.RunScheduleAndCancelTest with custom hooks, replacing the previous large inline test

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube