Conversation
Two deliberate behavior changes split out of the lint-sweep layer below, so each gets its own review and isolated blast radius. - audit_logger.go: NewAuditLogger now returns an error when config.ForwardToUrl() or config.Headers() fail, instead of silently falling back to a disabled no-op logger. A malformed AUDIT_LOGS_* config is a real misconfiguration; failing node startup surfaces it immediately instead of letting audit logging silently go dark. - webauthn.go: migrate off the deprecated go-webauthn Config.RPOrigin field to Config.RPOrigins, via a small rpOrigins() helper. An empty configured RPOrigin still produces a nil/empty RPOrigins slice, so webauthn.New's own "must provide at least one value to the 'RPOrigins' field" validation still fires at construction time, exactly as the deprecated single-value field did. Without this guard, an empty RPOrigin would instead pass construction as RPOrigins: [""] and only fail later, per-request, during origin comparison in login/registration - turning a loud startup error into a confusing runtime one. Tests added: - TestNewAuditLogger_ConfigErrors covers both new error returns. - TestBeginWebAuthnRegistration_EmptyRPOrigin locks in the empty-origin construction-time error. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
|
I see you updated files related to
|
kalverra
marked this pull request as ready for review
September 22, 2026 00:24
kalverra
added this pull request to stack #23793
September 22, 2026 00:24
product-security-plaid-production
Bot
requested review from
DylanTinianov and
justinkaseman
September 22, 2026 00:24
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
Supports