Skip to content

[CRE-6595] base engine decoupling - #23773

Draft
agparadiso wants to merge 9 commits into
developfrom
CRE-6595_base_engine_decoupling
Draft

agparadiso wants to merge 9 commits into
developfrom
CRE-6595_base_engine_decoupling

Conversation

@agparadiso

@agparadiso agparadiso commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Description

This pr is the first smallest effort to decouple the engine.

  • Introduces a WorkflowEngine interface
  • decouples the current/legacy engine.go into base_engine (common behavior) and engine.go behavior only valid for that engine
  • introduces an CoordinatedEngine that reuses the base_engine and reflects the new engine we are building in which is execution focus only.

Deployment Validation: existing canaries
This change does not alter behavior, the new engine is still not wired. so having existing canaries 🟢 should be enough

CRE-6595

Requires

Supports

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@trunk-io

trunk-io Bot commented Sep 17, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@agparadiso
agparadiso force-pushed the CRE-6595_base_engine_decoupling branch from d344c25 to 7fd60ae Compare September 18, 2026 09:11
@agparadiso
agparadiso force-pushed the CRE-6595_base_engine_decoupling branch from 7fd60ae to 0085e1a Compare September 18, 2026 09:44
Comment thread core/services/workflows/v2/base_engine.go Outdated
Comment thread core/services/workflows/v2/base_engine.go Outdated
Comment thread core/services/workflows/v2/engine.go Outdated
@agparadiso
agparadiso force-pushed the CRE-6595_base_engine_decoupling branch from ccd663c to 3679beb Compare September 21, 2026 09:51
@agparadiso
agparadiso force-pushed the CRE-6595_base_engine_decoupling branch 2 times, most recently from fe7d52d to 7f8a407 Compare September 22, 2026 16:17
@agparadiso
agparadiso force-pushed the CRE-6595_base_engine_decoupling branch from 7f8a407 to d13e179 Compare September 22, 2026 17:36
@cl-sonarqube-production

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants