feat(cre): allow JD DON name override for job proposal - #23766
Open
Krish-vemula wants to merge 2 commits into
Open
Krish-vemula wants to merge 2 commits into
Krish-vemula wants to merge 2 commits into
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
|
|
Krish-vemula
marked this pull request as ready for review
September 18, 2026 18:10
product-security-plaid-production
Bot
requested review from
george-dorin and
gustavogama-cll
September 18, 2026 18:11
amit-momin
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ProposeStandardCapabilityJobbuilds its JD filter asdon-<DONName>, assuming a DON's capabilities registry name matches the label on its nodes. Per-chain DONs are carved out of a shared DON, so the nodes keep the shared label and proposal fails:Explicit node IDs don't help the sequence queries JD by label first. The alternative is relabelling every node for every new DON
Change
Optional
JDDONName, used only for JD node lookup and defaulting toDONName.DONNamestill identifies the DON in logs and errors. Exposed on the EVM changeset and the two generic entry points.Solana/Aptos/Stellar are in this diff —
proposeAndReportis now a wrapper delegating with an empty JD name, so their behavior is identical.Compatibility
Additive and optional; empty reproduces previous behavior exactly.
omitemptyon both tags, so existing payloads are unchanged. No existing test modified.Payloads decode with
DisallowUnknownFields(), so settingjdDonNameon a changeset that doesn't declare it fails loudly at load rather than silently.Testing
TestProposeStandardCapabilityJob_Apply_JDDONNamecovers the override resolving nodes and the unset case still failing.Build, vet and
./cre/jobs/...pass.