fix testdb setup to ensure you can createrole#22973
Open
se3000 wants to merge 1 commit into
Open
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
se3000
force-pushed
the
se3000/setup-testdb-createrole
branch
2 times, most recently
from
d5a5155 to
2c38cb8
Compare
The heavyweight migration tests now use pgtestdb, which provisions an isolated role (pgtdbuser) per test run. The dev user created by this script only had CREATEDB, so those tests failed with: could not create pgtestdb user: failed to create role pgtdbuser: ERROR: permission denied to create role (SQLSTATE 42501) Grant CREATEROLE alongside the existing CREATEDB so a fresh setup works. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> fix test db setup to ensure you can create roles
se3000
force-pushed
the
se3000/setup-testdb-createrole
branch
from
2c38cb8 to
558ce04
Compare
|
product-security-plaid-production
Bot
requested review from
patrickhuie19 and
prashantkumar1982
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this issue when running through the test setup instructions in the readme. I believe all it takes to recreate the issue was to run
make testdb-forceand thengo test ./core/store/migrate/.