H-10:

[FelixFan1992]

No description provided.

[github-actions]

Soroban Contract Test Coverage

93.02% line coverage — 23401 / 25158 lines hit

Metric	Hit	Total	Coverage
Lines	23401	25158	93.02%
Functions	1508	1836	82.14%
Regions	42634	45550	93.60%

Per-Contract Breakdown

Contract	Lines (Hit / Total)	Line Cov	Funcs (Hit / Total)	Func Cov
other	23401 / 25158	93.0%	1508 / 1836	82.1%

Full file-level coverage report

Filename                                                 Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
ccip-ramp-registry/src/lib.rs                                188                75    60.11%           8                 3    62.50%         104                41    60.58%           0                 0         -
ccip-ramp-registry/src/test.rs                               214                 0   100.00%           5                 0   100.00%         128                 0   100.00%           0                 0         -
ccip-ramp-registry/src/types.rs                               83                11    86.75%          17                 6    64.71%          83                11    86.75%           0                 0         -
ccvs/committee-verifier/src/lib.rs                           588                54    90.82%          26                 2    92.31%         382                10    97.38%           0                 0         -
ccvs/committee-verifier/src/test.rs                         1300                25    98.08%          48                 2    95.83%         587                13    97.79%           0                 0         -
ccvs/committee-verifier/src/types.rs                          17                 8    52.94%           6                 5    16.67%          14                 7    50.00%           0                 0         -
ccvs/versioned-verifier-resolver/src/lib.rs                  287                21    92.68%          14                 1    92.86%         162                 4    97.53%           0                 0         -
ccvs/versioned-verifier-resolver/src/test.rs                 680                 9    98.68%          20                 0   100.00%         359                 3    99.16%           0                 0         -
ccvs/versioned-verifier-resolver/src/types.rs                 89                 6    93.26%          16                 4    75.00%          83                 4    95.18%           0                 0         -
common/authorization/src/allowlist.rs                        167                51    69.46%          12                 4    66.67%         110                40    63.64%           0                 0         -
common/authorization/src/lib.rs                              426                27    93.66%          16                 0   100.00%         277                16    94.22%           0                 0         -
common/authorization/src/ownable.rs                           92                 3    96.74%           8                 0   100.00%          57                 1    98.25%           0                 0         -
common/authorization/src/test.rs                            1195                 0   100.00%          57                 0   100.00%         462                 0   100.00%           0                 0         -
common/guard/src/initializable.rs                             30                 1    96.67%           4                 0   100.00%          22                 1    95.45%           0                 0         -
common/guard/src/lib.rs                                       32                 1    96.88%           4                 0   100.00%          22                 0   100.00%           0                 0         -
common/guard/src/test.rs                                     101                 0   100.00%           8                 0   100.00%          47                 0   100.00%           0                 0         -
common/helpers/src/curse_checkable.rs                        103                24    76.70%           6                 1    83.33%          56                12    78.57%           0                 0         -
common/helpers/src/fee_math.rs                               421                 2    99.52%          30                 0   100.00%         244                 1    99.59%           0                 0         -
common/helpers/src/finality_codec.rs                          52                 1    98.08%           3                 0   100.00%          41                 0   100.00%           0                 0         -
common/helpers/src/map_updater.rs                             94                15    84.04%           7                 3    57.14%          39                 8    79.49%           0                 0         -
common/helpers/src/soroban_invoke.rs                         277                 7    97.47%          12                 0   100.00%         115                 1    99.13%           0                 0         -
common/helpers/src/validation.rs                              42                 0   100.00%           2                 0   100.00%          24                 0   100.00%           0                 0         -
common/interfaces/src/ccip_receiver.rs                         6                 6     0.00%           6                 6     0.00%           6                 6     0.00%           0                 0         -
common/interfaces/src/committee_verifier.rs                    6                 6     0.00%           6                 6     0.00%           6                 6     0.00%           0                 0         -
common/interfaces/src/executor.rs                              3                 3     0.00%           3                 3     0.00%           3                 3     0.00%           0                 0         -
common/interfaces/src/fee_quoter.rs                           13                13     0.00%          13                13     0.00%          13                13     0.00%           0                 0         -
common/interfaces/src/offramp.rs                               4                 4     0.00%           4                 4     0.00%           4                 4     0.00%           0                 0         -
common/interfaces/src/onramp.rs                                4                 4     0.00%           4                 4     0.00%           4                 4     0.00%           0                 0         -
common/interfaces/src/ramp_registry.rs                         4                 4     0.00%           4                 4     0.00%           4                 4     0.00%           0                 0         -
common/interfaces/src/router.rs                                6                 6     0.00%           6                 6     0.00%           6                 6     0.00%           0                 0         -
common/interfaces/src/siloed_lock_release_pool.rs             14                14     0.00%          14                14     0.00%          14                14     0.00%           0                 0         -
common/interfaces/src/token_admin_registry.rs                  1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
common/interfaces/src/token_pool.rs                           13                13     0.00%          13                13     0.00%          13                13     0.00%           0                 0         -
common/interfaces/src/versioned_verifier_resolver.rs           4                 4     0.00%           4                 4     0.00%           4                 4     0.00%           0                 0         -
common/message/src/lib.rs                                    673                50    92.57%          34                 4    88.24%         331                 9    97.28%           0                 0         -
common/message/src/test.rs                                   963                10    98.96%          40                 0   100.00%         475                 0   100.00%           0                 0         -
common/pool/src/decimals.rs                                  109                10    90.83%           6                 0   100.00%          76                 3    96.05%           0                 0         -
common/pool/src/lib.rs                                       648                47    92.75%          41                 1    97.56%         562                34    93.95%           0                 0         -
common/pool/src/rate_limit.rs                                180                 7    96.11%           9                 0   100.00%         145                 3    97.93%           0                 0         -
common/pool/src/types.rs                                      25                16    36.00%          19                16    15.79%          43                16    62.79%           0                 0         -
common/signature/src/config.rs                                44                12    72.73%           6                 2    66.67%          28                 5    82.14%           0                 0         -
common/signature/src/quorum.rs                                68                 1    98.53%           2                 0   100.00%          44                 1    97.73%           0                 0         -
common/signature/src/scheme.rs                                45                 0   100.00%           2                 0   100.00%          29                 0   100.00%           0                 0         -
cre/forwarder/src/error.rs                                     8                 3    62.50%           1                 0   100.00%           8                 3    62.50%           0                 0         -
cre/forwarder/src/lib.rs                                     597                22    96.31%          26                 0   100.00%         417                 4    99.04%           0                 0         -
cre/forwarder/src/test.rs                                   3426                14    99.59%         151                 2    98.68%        1430                 8    99.44%           0                 0         -
cre/forwarder/src/types.rs                                    62                 6    90.32%          10                 6    40.00%          36                 6    83.33%           0                 0         -
cre/test/read_fixture/src/lib.rs                             125               125     0.00%          33                33     0.00%         103               103     0.00%           0                 0         -
cre/test/receiver/src/lib.rs                                  53                53     0.00%           5                 5     0.00%          26                26     0.00%           0                 0         -
cre/test/rejecting_receiver/src/lib.rs                         3                 3     0.00%           1                 1     0.00%           8                 8     0.00%           0                 0         -
executor/src/lib.rs                                          376                53    85.90%          15                 0   100.00%         264                26    90.15%           0                 0         -
executor/src/test.rs                                         863                 4    99.54%          29                 1    96.55%         378                 4    98.94%           0                 0         -
executor/src/types.rs                                          9                 3    66.67%           4                 3    25.00%           9                 3    66.67%           0                 0         -
fee-quoter/src/lib.rs                                        749               158    78.91%          20                 3    85.00%         513                95    81.48%           0                 0         -
fee-quoter/src/test.rs                                       861                 0   100.00%          17                 0   100.00%         428                 0   100.00%           0                 0         -
fee-quoter/src/types.rs                                       13                13     0.00%          13                13     0.00%          13                13     0.00%           0                 0         -
mcms/src/constants.rs                                         10                 0   100.00%           2                 0   100.00%           6                 0   100.00%           0                 0         -
mcms/src/crypto.rs                                           202                 3    98.51%           7                 0   100.00%         109                 2    98.17%           0                 0         -
mcms/src/encoding.rs                                         328                 8    97.56%          15                 0   100.00%         196                 3    98.47%           0                 0         -
mcms/src/error.rs                                              8                 3    62.50%           1                 0   100.00%           8                 3    62.50%           0                 0         -
mcms/src/lib.rs                                              715                54    92.45%          17                 0   100.00%         511                23    95.50%           0                 0         -
mcms/src/test.rs                                            2439                39    98.40%          71                 2    97.18%        1150                16    98.61%           0                 0         -
mcms/src/types.rs                                             10                10     0.00%          10                10     0.00%          10                10     0.00%           0                 0         -
offramp/src/lib.rs                                          1063               449    57.76%          29                 9    68.97%         645               229    64.50%           0                 0         -
offramp/src/test.rs                                         1448                 3    99.79%          51                 0   100.00%         625                 0   100.00%           0                 0         -
offramp/src/types.rs                                          24                 6    75.00%           6                 5    16.67%          22                 6    72.73%           0                 0         -
onramp/src/lib.rs                                           1386               125    90.98%          32                 2    93.75%         876                45    94.86%           0                 0         -
onramp/src/test.rs                                          4224                25    99.41%          96                 3    96.88%        2175                50    97.70%           0                 0         -
onramp/src/types.rs                                           28                 9    67.86%           6                 5    16.67%          24                 7    70.83%           0                 0         -
pools/burn-mint-pool/src/lib.rs                              508                95    81.30%          36                 8    77.78%         376                43    88.56%           0                 0         -
pools/burn-mint-pool/src/test.rs                            3937                34    99.14%          95                 7    92.63%        2560                79    96.91%           0                 0         -
pools/lock-release-pool/src/lib.rs                           653               195    70.14%          43                18    58.14%         462               105    77.27%           0                 0         -
pools/lock-release-pool/src/test.rs                         2934                34    98.84%          68                 7    89.71%        1885                79    95.81%           0                 0         -
pools/siloed-lock-release-pool/src/lib.rs                    665               237    64.36%          45                21    53.33%         476               146    69.33%           0                 0         -
pools/siloed-lock-release-pool/src/test.rs                  1681                22    98.69%          51                 4    92.16%         976                42    95.70%           0                 0         -
pools/token-lock-box/src/lib.rs                              197                17    91.37%          13                 1    92.31%         113                 2    98.23%           0                 0         -
pools/token-lock-box/src/test.rs                             257                 0   100.00%           7                 0   100.00%          73                 0   100.00%           0                 0         -
registry/src/lib.rs                                            8                 0   100.00%           1                 0   100.00%           3                 0   100.00%           0                 0         -
registry/src/test.rs                                          27                 0   100.00%           1                 0   100.00%          11                 0   100.00%           0                 0         -
rmn_proxy/src/lib.rs                                          66                12    81.82%           5                 1    80.00%          34                 3    91.18%           0                 0         -
rmn_proxy/src/test.rs                                        279                 0   100.00%          11                 0   100.00%          91                 0   100.00%           0                 0         -
rmn_remote/src/lib.rs                                        302                26    91.39%          16                 1    93.75%         171                 9    94.74%           0                 0         -
rmn_remote/src/test.rs                                       393                 0   100.00%          14                 0   100.00%         133                 0   100.00%           0                 0         -
router/src/lib.rs                                            627                89    85.81%          19                 1    94.74%         394                43    89.09%           0                 0         -
router/src/test.rs                                          1347                 0   100.00%          33                 0   100.00%         571                 0   100.00%           0                 0         -
router/src/test_panic_receiver.rs                              5                 0   100.00%           2                 0   100.00%           5                 0   100.00%           0                 0         -
router/src/types.rs                                            3                 3     0.00%           3                 3     0.00%           3                 3     0.00%           0                 0         -
timelock/src/encoding.rs                                     329                 3    99.09%          15                 0   100.00%         182                 1    99.45%           0                 0         -
timelock/src/error.rs                                          6                 2    66.67%           1                 0   100.00%           6                 2    66.67%           0                 0         -
timelock/src/lib.rs                                          679               261    61.56%          33                11    66.67%         382               132    65.45%           0                 0         -
timelock/src/roles.rs                                         82                30    63.41%           7                 2    71.43%          62                21    66.13%           0                 0         -
timelock/src/storage.rs                                      227                51    77.53%          14                 1    92.86%         124                22    82.26%           0                 0         -
timelock/src/test.rs                                         798                13    98.37%          24                 0   100.00%         296                 0   100.00%           0                 0         -
timelock/src/types.rs                                          4                 4     0.00%           4                 4     0.00%           4                 4     0.00%           0                 0         -
token-admin-registry/src/lib.rs                              368                23    93.75%          18                 1    94.44%         257                 4    98.44%           0                 0         -
token-admin-registry/src/test.rs                             825                 0   100.00%          21                 0   100.00%         287                 0   100.00%           0                 0         -
token-admin-registry/src/types.rs                              2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                      45550              2916    93.60%        1836               328    82.14%       25158              1757    93.02%           0                 0         -```

</details>

> Commit `201a8771` | [Full CI run](https://github.com/smartcontractkit/chainlink-stellar/actions/runs/35787287171)

<!-- Sticky Pull Request Commentcontract-coverage -->

[github-actions]

Integration Test Coverage (excl. Token Pool)

total:														(statements)				5.2%

Full coverage report

[github-actions]

Integration Test Coverage (Token Pool)

total:														(statements)				2.9%

Full coverage report

Superseded by the follow-up review below — same points, rephrased as questions with reference links.

[JohnChangUK]

Removed my two fee_math.rs comments — both points are dust-level and not worth changing. Only two items stand: the duplicate fee check (inline on lib.rs) and the fee-quoter link_premium_percent == 0 question.

[github-actions]

Code coverage report:

Top package	main	H-10	diff
github.com/smartcontractkit/chainlink-stellar/ccv	59.94%	59.94%	+0.00%
github.com/smartcontractkit/chainlink-stellar/cmd	0.00%	0.00%	+0.00%
github.com/smartcontractkit/chainlink-stellar/relayer	66.98%	66.98%	+0.00%