add CHAIN_TYPE_STELLAR and CHAIN_TYPE_CANTON#416
Merged
Conversation
- Add enum values to feedsmanager.proto (orchestrator) and node.proto (job-distributor), both at values 8 and 9 - Regenerate affected .pb.go files
🦋 Changeset detectedLatest commit: 3aa1194 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).
|
jkongie
approved these changes
Jun 30, 2026
graham-chainlink
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
CHAIN_TYPE_STELLAR = 8andCHAIN_TYPE_CANTON = 9to theChainTypeenum in bothorchestrator/feedsmanager/feedsmanager.protoandjob-distributor/v1/node/node.proto.Why: The standalone CCIP committee verifier (chainlink-ccv) pushes its onchain signing key to JD on startup via
feedsmanager.UpdateNode, storing the address inOCR2Config.OcrKeyBundle.OnchainSigningAddressper chain. Deployment tooling then reads it back viaNodeService.ListNodeChainConfigsto configure onchain contracts. Both Stellar and Canton need to participate in this flow, but neither chain type is currently in the enum, blocking the feature for those families. See smartcontractkit/chainlink-ccv#1205 for the full context.No Go code changes in JD are needed beyond the dep bump. The chain family mapping in JD uses
strings.TrimPrefix("CHAIN_TYPE_", ...)and a proto enum value lookup, so new entries are handled automatically.