OEV-1414 Add feedAddress to meta metrics by cll-gg · Pull Request #502 · smartcontractkit/chainlink-evm

cll-gg · 2026-07-14T12:00:03Z

What

Add feedAddress to meta client related metrics

Why

To improve observability

github-actions · 2026-07-14T12:02:14Z

⚠️ API Diff Results - `github.com/smartcontractkit/chainlink-evm`

⚠️ Breaking Changes (6)

`pkg/txm/clientwrappers/dualbroadcast.(*MetaClient)` (1)

SendRequest — Type changed:

func(
  context.Context, 
  *github.com/smartcontractkit/chainlink-evm/pkg/txm/types.Transaction, 
  *github.com/smartcontractkit/chainlink-evm/pkg/txm/types.Attempt, 
  string, 
  + github.com/ethereum/go-ethereum/common.Address, 
  github.com/ethereum/go-ethereum/common.Address
)
(*MetacalldataResponse, error)

`pkg/txm/clientwrappers/dualbroadcast.(*MetaMetrics)` (5)

RecordBidsReceived — Type changed:

func(
  context.Context, 
  int, 
  + github.com/ethereum/go-ethereum/common.Address
)

RecordLatency — Type changed:

func(
  context.Context, 
  time.Duration, 
  + github.com/ethereum/go-ethereum/common.Address
)

RecordSendOperationError — Type changed:

func(
  context.Context, 
  + github.com/ethereum/go-ethereum/common.Address
)

RecordSendRequestError — Type changed:

func(
  context.Context, 
  + github.com/ethereum/go-ethereum/common.Address
)

RecordStatusCode — Type changed:

func(
  context.Context, 
  int, 
  + github.com/ethereum/go-ethereum/common.Address
)

📄 View full apidiff report

Copilot

Pull request overview

This PR updates Meta client OTEL metrics to include a per-feed/per-contract address dimension, improving observability by allowing status/latency/errors/bid counts to be segmented by destination.

Changes:

Added a new feedAddress parameter to MetaMetrics recording methods and propagated it through MetaClient call sites.
Attached an address attribute to Meta-related metrics (status code, latency, bids received, and error counters).
Updated unit tests to cover the new method signatures.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

File	Description
pkg/txm/clientwrappers/dualbroadcast/meta_metrics.go	Adds an address attribute to Meta metrics and updates metric recording method signatures.
pkg/txm/clientwrappers/dualbroadcast/meta_metrics_test.go	Updates tests to call the updated MetaMetrics methods with a feed address argument.
pkg/txm/clientwrappers/dualbroadcast/meta_client.go	Passes an address through when recording Meta metrics during request/operation lifecycle.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

dimriou · 2026-07-15T09:42:16Z

+func (m *MetaMetrics) RecordStatusCode(ctx context.Context, statusCode int, feedAddress string) {
 	m.statusCodeCounter.Add(ctx, 1,
 		metric.WithAttributes(
 			attribute.String("chainID", m.chainID),
 			attribute.String("statusCode", strconv.Itoa(statusCode)),
+			attribute.String("feedAddress", strings.ToLower(feedAddress)),


You can pass feedAddress as a common.Address param and avoid spamming txMeta.FwdrDestAddress.Hex() in the caller and also avoid strings.ToLower(feedAddress) since all callers will be consistent with .Hex() call

Suggested change

func (m *MetaMetrics) RecordStatusCode(ctx context.Context, statusCode int, feedAddress string) {

m.statusCodeCounter.Add(ctx, 1,

metric.WithAttributes(

attribute.String("chainID", m.chainID),

attribute.String("statusCode", strconv.Itoa(statusCode)),

attribute.String("feedAddress", strings.ToLower(feedAddress)),

func (m *MetaMetrics) RecordStatusCode(ctx context.Context, statusCode int, feedAddress common.Address) {

m.statusCodeCounter.Add(ctx, 1,

metric.WithAttributes(

attribute.String("chainID", m.chainID),

attribute.String("statusCode", strconv.Itoa(statusCode)),

attribute.String("feedAddress", feedAddress.Hex()),

Ah yes, passing address is a lot nicer 👍
Will update.

also avoid strings.ToLower(feedAddress) since all callers will be consistent with .Hex() call

WDYM with this?
The toLower call is to prevent mixed-case addresses from being labels in PromQL, because PromQL doesn't have a lowercase function, making it impossible to match a mixed-case address with a lowercased address.

dimriou · 2026-07-15T09:54:41Z

 		tx.AttemptCount == 1 && !tx.IsPurgeable {
 		// Auction & Validate
-		meta, err := a.SendRequest(ctx, tx, attempt, *meta.DualBroadcastParams, tx.ToAddress)
+		meta, err := a.SendRequest(ctx, tx, attempt, txMeta, tx.ToAddress)


SendRequest only has one caller. It would be better if we explode the params and separate the DualBroadcastParams from the feedAddress. We can pass both independently keep the DualBroadcastParams as is and just pass feeAddress to the underlying callers. This avoid spamming *txMeta.FwdrDestAddress .

Suggested change

meta, err := a.SendRequest(ctx, tx, attempt, txMeta, tx.ToAddress)

meta, err := a.SendRequest(ctx, tx, attempt, *meta.DualBroadcastParams, tx.ToAddress, feedAddress)

Makes sense, updated

dimriou · 2026-07-15T09:55:35Z

+	if txMeta == nil || txMeta.FwdrDestAddress == nil || txMeta.DualBroadcastParams == nil {
+		return nil, errors.New("missing tx meta fields for dual broadcast request")
+	}


I would consider this redundant as we make the same check right before we call SendRequest.

And there's only one caller, fair

dimriou · 2026-07-15T09:56:53Z

+	txMeta, err := tx.GetMeta()
 	if err != nil {
 		return err
 	}

 	// #1
-	if meta != nil &&
-		meta.DualBroadcast != nil && *meta.DualBroadcast && meta.DualBroadcastParams != nil && meta.FwdrDestAddress != nil &&
+	if txMeta != nil &&
+		txMeta.DualBroadcast != nil && *txMeta.DualBroadcast && txMeta.DualBroadcastParams != nil && txMeta.FwdrDestAddress != nil &&


No need to rename this local variable, meta seems clear enough.

Agree on its own, but consider line 207, there we reassign/shadow meta to a different variable, so it changes from TxMeta struct to a MetacalldataResponse struct.
This makes it impossible to call meta.FwdrDestAddress after line 207.

Ok makes sense. We could also rename the returned value of SendRequest since meta is now used inside here, whatever feels best.

Good point, I've opted for renaming the returned value from SendRequest instead

dimriou · 2026-07-15T09:59:56Z

 	m.latencyHistogram.Record(ctx, duration.Milliseconds(),
 		metric.WithAttributes(
 			attribute.String("chainID", m.chainID),
+			attribute.String("feedAddress", strings.ToLower(feedAddress.Hex())),


I would consider not using strings.ToLower as this forces other callers to ensure they call it in other places to stay consistent. If they miss it, then some attributes will be upper case and other lower case. Just by calling .Hex() , which is required by the attribute param, we ensure everyone does the same.

The toLower call is to prevent mixed-case addresses from being labels in PromQL, because PromQL doesn't have a lowercase function, making it impossible to match a mixed-case address with a lowercased address.

We encountered this already in matching SDS metrics (lowercased addresses) with RDDPE metrics (checksummed addresses), see https://github.com/smartcontractkit/rdd-prometheus-exporter/pull/139.

But Hex() doesn't return a random mixed case, it returns the EIP55-compliant hex string. Can't we use that standard for querying?

True, that's likely better and more consistent. I'll have to update SDS for that

Removed the lowercase here

dimriou

Nice, looks pretty.

OEV-1414 Add feedAddress to meta metrics

65b7ebc

Emit feed address as lowercase to enable matching in PromQL

ca9df5b

cll-gg marked this pull request as ready for review July 14, 2026 16:32

cll-gg requested review from a team and dimriou as code owners July 14, 2026 16:32

Copilot AI review requested due to automatic review settings July 14, 2026 16:32

cll-gg requested a review from a team as a code owner July 14, 2026 16:32

product-security-plaid-production Bot requested review from dhaidashenko and vyzaldysanchez July 14, 2026 16:32

Copilot started reviewing on behalf of cll-gg July 14, 2026 16:32 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

cll-gg and others added 5 commits July 15, 2026 09:08

PR feedback

cdef5be

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

PR feedback

df17b55

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

PR feedback

870b26c

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

PR feedback

222f7e3

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Use the forwarder destination address, make label consistent

42ee7f9

cll-gg requested a review from Copilot July 15, 2026 08:28

Copilot started reviewing on behalf of cll-gg July 15, 2026 08:29 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Comment thread pkg/txm/clientwrappers/dualbroadcast/meta_client.go Outdated

PR feedback: add validation

ab0abe7

cll-gg requested a review from Copilot July 15, 2026 09:34

Copilot started reviewing on behalf of cll-gg July 15, 2026 09:35 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Comment thread pkg/txm/clientwrappers/dualbroadcast/meta_client.go Outdated

Comment thread pkg/txm/clientwrappers/dualbroadcast/meta_client.go Outdated

dimriou reviewed Jul 15, 2026

View reviewed changes

Comment thread pkg/txm/clientwrappers/dualbroadcast/meta_metrics.go Outdated

dimriou reviewed Jul 15, 2026

View reviewed changes

Comment thread pkg/txm/clientwrappers/dualbroadcast/meta_metrics.go Outdated

Use address in metrics

76ee589

cll-gg requested a review from dimriou July 15, 2026 09:49

dimriou reviewed Jul 15, 2026

View reviewed changes

cll-gg added 2 commits July 15, 2026 11:23

Remove redundant validation

6d4e16c

PR feedback: explode params instead of passing TxMeta

9e4052a

cll-gg requested a review from dimriou July 15, 2026 10:28

cll-gg added 2 commits July 15, 2026 13:40

Rename to response instead

23909ed

Keep the checksum addresses

7449110

dimriou approved these changes Jul 15, 2026

View reviewed changes

	meta, err := a.SendRequest(ctx, tx, attempt, txMeta, tx.ToAddress)
	meta, err := a.SendRequest(ctx, tx, attempt, *meta.DualBroadcastParams, tx.ToAddress, feedAddress)

Uh oh!

Conversation

cll-gg commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Uh oh!

github-actions Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-evm

⚠️ Breaking Changes (6)

pkg/txm/clientwrappers/dualbroadcast.(*MetaClient) (1)

pkg/txm/clientwrappers/dualbroadcast.(*MetaMetrics) (5)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cll-gg Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dimriou left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

cll-gg commented Jul 14, 2026 •

edited

Loading

github-actions Bot commented Jul 14, 2026 •

edited

Loading

⚠️ API Diff Results - `github.com/smartcontractkit/chainlink-evm`

`pkg/txm/clientwrappers/dualbroadcast.(*MetaClient)` (1)

`pkg/txm/clientwrappers/dualbroadcast.(*MetaMetrics)` (5)

cll-gg Jul 15, 2026 •

edited

Loading