[CRE-5836] Remove legacy workflows/wasm guest SDK - #2416
Merged
Merged
Conversation
Contributor
|
nolag
approved these changes
Sep 25, 2026
Deletes the legacy v1 DAG guest SDK package (runner, runner_wasip1, runner_notwasip1, sdk + tests). Zero importers remain since C2 removed the legacy guest test modules. Part of CRE-5836.
bolekk
force-pushed
the
keystone_wasm_cleanup_c5
branch
from
September 25, 2026 18:44
aab7e3b to
672edac
Compare
bolekk
enabled auto-merge
September 25, 2026 18:44
vyzaldysanchez
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of CRE-5836 (DAG WASM removal). Follow-up to #2413.
Deletes the legacy v1 DAG guest SDK at the
pkg/workflows/wasmpackage root:runner.go,runner_wasip1.go,runner_notwasip1.go,sdk.go+ tests — 6 files, −966 lines. Zero importers remain since #2382 removed the legacy guest test modules;pkg/workflows/wasmnow contains only the v2hostandpb(pb is removed in the next step, together with the sdk root).Verification:
go build ./...greengo test ./pkg/workflows/...greenmake lintgreenGOOS=wasip1build green (rawsdk + host/test modules + standard_tests)Deployment Validation: pure deletion of prod-dead code (legacy jobs already rejected at creation) — no behavior change; existing canaries.